lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9c1ab010-1436-4c54-9fa5-418472a9427f@gmail.com>
Date: Wed, 28 Aug 2024 20:48:42 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Dorine Tipo <dorine.a.tipo@...il.com>,
 Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8712: Align parenthesis in usb_ops_linux.c

On 8/28/24 10:29, Dorine Tipo wrote:
> Fix the parenthesis alignment in r8712_read_port() function to match
> the opening parenthesis.
> This improves code readability and adheres to the kernel coding style.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@...il.com>
> ---
> Changelog:
> V2: Edited the subject line to fix a typo and make it more unique as
>      suggested by Philipp.
>      Edited the description to include the reason for the change.
> 
>   drivers/staging/rtl8712/usb_ops_linux.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c
> index 0a3451cdc8a1..4a34824830e3 100644
> --- a/drivers/staging/rtl8712/usb_ops_linux.c
> +++ b/drivers/staging/rtl8712/usb_ops_linux.c
> @@ -221,7 +221,7 @@ static void r8712_usb_read_port_complete(struct urb *purb)
>   			fallthrough;
>   		case -EPROTO:
>   			r8712_read_port(padapter, precvpriv->ff_hwaddr, 0,
> -				  (unsigned char *)precvbuf);
> +					(unsigned char *)precvbuf);
>   			break;
>   		case -EINPROGRESS:
>   			netdev_err(padapter->pnetdev, "ERROR: URB IS IN PROGRESS!\n");
> --
> 2.25.1
> 


Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> AW-NU120

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ