linux-kernel - Re: [PATCH] bcachefs: Switch to memalloc_flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <gutyvxwembnzaoo43dzvmnpnbmj6pzmypx5kcyor3oeomgzkva@6colowp7crgk>
Date: Wed, 28 Aug 2024 15:11:19 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Matthew Wilcox <willy@...radead.org>
Cc: linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, Michal Hocko <mhocko@...e.com>, 
	Dave Chinner <dchinner@...hat.com>
Subject: Re: [PATCH] bcachefs: Switch to memalloc_flags_do() for vmalloc
 allocations

On Wed, Aug 28, 2024 at 07:48:43PM GMT, Matthew Wilcox wrote:
> On Wed, Aug 28, 2024 at 10:06:36AM -0400, Kent Overstreet wrote:
> > vmalloc doesn't correctly respect gfp flags - gfp flags aren't used for
> > pte allocation, so doing vmalloc/kvmalloc allocations with reclaim
> > unsafe locks is a potential deadlock.
> 
> Kent, the approach you've taken with this was NACKed.  You merged it
> anyway (!).  Now you're spreading this crap further, presumably in an effort
> to make it harder to remove.

Excuse me? This is fixing a real issue which has been known for years.

It was decided _years_ ago that PF_MEMALLOC flags were how this was
going to be addressed.

> Stop it.  Work with us to come up with an acceptable approach.  I
> think there is one that will work, but you need to listen to the people
> who're giving you feedback because Linux is too big of a code-base for
> you to understand everything.

No, you guys need to stop pushing broken shit.