linux-kernel - Re: [PATCH v1 1/5] pinctrl: intel: Move debounce validation out of the lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zs94qgBBXtF2csH8@smile.fi.intel.com>
Date: Wed, 28 Aug 2024 22:21:14 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/5] pinctrl: intel: Move debounce validation out of
 the lock

On Wed, Aug 28, 2024 at 09:38:34PM +0300, Andy Shevchenko wrote:
> There is no need to validate debounce value under the lock.
> Move it outside.

...

> +	if (v) {
>  		/* Enable glitch filter and debouncer */
>  		value0 |= PADCFG0_PREGFRXSEL;
>  		value2 |= v << PADCFG2_DEBOUNCE_SHIFT;
>  		value2 |= PADCFG2_DEBEN;

This has a bug, I fix it locally for now and will wait for the comments for
the rest of the series.

> +	} else {
> +		/* Disable glitch filter and debouncer */
> +		value0 &= ~PADCFG0_PREGFRXSEL;
> +		value2 &= ~(PADCFG2_DEBEN | PADCFG2_DEBOUNCE_MASK);
>  	}

-- 
With Best Regards,
Andy Shevchenko