linux-kernel - Re: [PATCH v4 1/1] dt-bindings: hwmon: Convert ltc2978.txt to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d4c0da72-4e6c-463a-9709-73147adbc3f6@roeck-us.net>
Date: Wed, 28 Aug 2024 13:21:30 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Frank Li <Frank.li@....com>
Cc: robh@...nel.org, broonie@...nel.org, conor+dt@...nel.org,
 devicetree@...r.kernel.org, imx@...ts.linux.dev, jdelvare@...e.com,
 krzk+dt@...nel.org, lgirdwood@...il.com, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/1] dt-bindings: hwmon: Convert ltc2978.txt to yaml

On 8/28/24 12:50, Frank Li wrote:
> On Wed, Aug 28, 2024 at 12:40:59PM -0700, Guenter Roeck wrote:
>> On 8/28/24 11:35, Frank Li wrote:
>>> On Wed, Aug 28, 2024 at 10:06:25AM -0700, Guenter Roeck wrote:
>>>> On 8/28/24 09:41, Frank Li wrote:
>>>>> Convert binding doc ltc2978.txt to yaml format.
>>>>> Additional change:
>>>>> - add i2c node.
>>>>> - basic it is regulator according to example, move it under regulator.
>>>>>
>>>>> Fix below warning:
>>>>> arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: /soc/i2c@...0000/i2c-mux@...i2c@...egulator@5c:
>>>>> 	failed to match any schema with compatible: ['lltc,ltc3882']
>>>>>
>>>>> Signed-off-by: Frank Li <Frank.Li@....com>
>>>>> ---
>>>>> Change from v3 to v4
>>>>> - keep under hwmon directory.
>>>>> Change from v2 to v3
>>>>> - put my name into maintainers.
>>>>> change from v1 to v2
>>>>> - maintainer change to Mark Brown <broonie@...nel.org> (regulator maintainer)
>>>>> - update title to (from ltc2978 data sheet).
>>>>> octal, digital power-supply monitor, supervisor, sequencer, and margin controller.
>>>>> ---
>>>>>     .../bindings/hwmon/lltc,ltc2972.yaml          | 94 +++++++++++++++++++
>>>>>     .../devicetree/bindings/hwmon/ltc2978.txt     | 62 ------------
>>>>
>>>> I still fail to understand the rationale for renaming the file from ltc2978
>>>> to ltc2972. I can see that 2972 is currently the alphabetically first supported
>>>> chip, but that is, in my opinion, irrelevant, and it will change.
>>>
>>> Conor suggest use one of compatbile string as filename. I random pick one.
>>> I am not care about filename. If you like, I can use lltc,ltc2978.yaml
>>> or other filename.
>>>
>>
>> The rename results in a disconnect between driver name and the associated
>> devicetree file. I fail to see the point of introducing that disconnect.
> 
> what's name do you prefered? lltc,ltc2978.yaml?
> 

Yes.

Guenter