linux-kernel - Re: [PATCH v1] drivers:spi:Insert the missing pci_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc9d3f45-818e-4466-be73-e4fac3cfacd5@sirena.org.uk>
Date: Wed, 28 Aug 2024 21:54:31 +0100
From: Mark Brown <broonie@...nel.org>
To: Yang Ruibin <11162571@...o.com>
Cc: Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	linux-arm-kernel@...ts.infradead.org, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers:spi:Insert the missing pci_dev_put()before
 return

On Tue, Aug 20, 2024 at 07:12:35AM -0400, Yang Ruibin wrote:
> Increase the reference count by calling pci_get_slot(), and remember to 
> decrement the reference count by calling pci_dev_put().

I haven't seen exactly how but your patch is corrupted and can't be
applied:

Applying: spi: Insert the missing pci_dev_put() before return
error: corrupt patch at line 18
error: could not build fake ancestor
Patch failed at 0001 spi: Insert the missing pci_dev_put() before return

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)