linux-kernel - Re: [PATCHv4 net-next] net: ag71xx: get reset control using devm api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aeef6dd8-694c-4056-b6df-b1e660daedad@intel.com>
Date: Wed, 28 Aug 2024 14:09:34 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Rosen Penev <rosenp@...il.com>, <netdev@...r.kernel.org>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <linux@...linux.org.uk>, <linux-kernel@...r.kernel.org>,
	<o.rempel@...gutronix.de>, <p.zabel@...gutronix.de>
Subject: Re: [PATCHv4 net-next] net: ag71xx: get reset control using devm api



On 8/26/2024 12:28 PM, Rosen Penev wrote:
> Currently, the of variant is missing reset_control_put in error paths.
> The devm variant does not require it.
> 
> Allows removing mdio_reset from the struct as it is not used outside the
> function.
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>