linux-kernel - Re: [PATCH] MIPS: fw: Gracefully handle unknown firmware protocols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202408290501.kTATRaBZ-lkp@intel.com>
Date: Thu, 29 Aug 2024 06:15:09 +0800
From: kernel test robot <lkp@...el.com>
To: Bjørn Mork <bjorn@...k.no>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: oe-kbuild-all@...ts.linux.dev,
	"Steven J . Hill" <Steven.Hill@...tec.com>,
	linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bjørn Mork <bjorn@...k.no>,
	stable@...r.kernel.org
Subject: Re: [PATCH] MIPS: fw: Gracefully handle unknown firmware protocols

Hi Bjørn,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.11-rc5 next-20240828]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Bj-rn-Mork/MIPS-fw-Gracefully-handle-unknown-firmware-protocols/20240826-170643
base:   linus/master
patch link:    https://lore.kernel.org/r/20240824144133.1464835-1-bjorn%40mork.no
patch subject: [PATCH] MIPS: fw: Gracefully handle unknown firmware protocols
config: mips-bigsur_defconfig (https://download.01.org/0day-ci/archive/20240829/202408290501.kTATRaBZ-lkp@intel.com/config)
compiler: mips64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240829/202408290501.kTATRaBZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408290501.kTATRaBZ-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/mips/fw/lib/cmdline.c: In function 'fw_init_cmdline':
>> arch/mips/fw/lib/cmdline.c:25:65: error: 'CKSEG2' undeclared (first use in this function); did you mean 'CKSEG0'?
      25 |         if (fw_arg0 >= CKSEG0 || fw_arg1 < CKSEG0 || fw_arg1 >= CKSEG2) {
         |                                                                 ^~~~~~
         |                                                                 CKSEG0
   arch/mips/fw/lib/cmdline.c:25:65: note: each undeclared identifier is reported only once for each function it appears in


vim +25 arch/mips/fw/lib/cmdline.c

    18	
    19	#ifndef CONFIG_HAVE_PLAT_FW_INIT_CMDLINE
    20	void __init fw_init_cmdline(void)
    21	{
    22		int i;
    23	
    24		/* Validate command line parameters. */
  > 25		if (fw_arg0 >= CKSEG0 || fw_arg1 < CKSEG0 || fw_arg1 >= CKSEG2) {
    26			fw_argc = 0;
    27			_fw_argv = NULL;
    28		} else {
    29			fw_argc = (fw_arg0 & 0x0000ffff);
    30			_fw_argv = (int *)fw_arg1;
    31		}
    32	
    33		/* Validate environment pointer. */
    34		if (fw_arg2 < CKSEG0 || fw_arg2 >= CKSEG2)
    35			_fw_envp = NULL;
    36		else
    37			_fw_envp = (int *)fw_arg2;
    38	
    39		for (i = 1; i < fw_argc; i++) {
    40			strlcat(arcs_cmdline, fw_argv(i), COMMAND_LINE_SIZE);
    41			if (i < (fw_argc - 1))
    42				strlcat(arcs_cmdline, " ", COMMAND_LINE_SIZE);
    43		}
    44	}
    45	#endif
    46	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki