linux-kernel - Re: [PATCH net-next] net: ag71xx: update FIFO bits and descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKxU2N9us=0+b2xRJs_Y1SKx8rF=d6XmwTom9oQvBucH5=cYUA@mail.gmail.com>
Date: Wed, 28 Aug 2024 15:36:36 -0700
From: Rosen Penev <rosenp@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, 
	linux@...linux.org.uk, linux-kernel@...r.kernel.org, o.rempel@...gutronix.de, 
	p.zabel@...gutronix.de
Subject: Re: [PATCH net-next] net: ag71xx: update FIFO bits and descriptions

On Wed, Aug 28, 2024 at 3:29 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 28 Aug 2024 13:42:49 -0700 Rosen Penev wrote:
> > Taken from QCA SDK. No functional difference as same bits get applied.
>
> Are these used? Would be nice to heave your best guess on the impact
> this change will have in the commit message, for posterity scanning
> git logs a few months/years from now.
No impact. It's effectively a documentation fix.

I see ag71xx_wr(ag, AG71XX_REG_FIFO_CFG5, FIFO_CFG5_INIT); so yes, they're used.
>
> BTW missing CC netdev, feel free to resend without 24h wait.
That's embarrassing. Will do.