Message-Id: <172488869750.1836577.14830231532115665875.robh@kernel.org>
Date: Wed, 28 Aug 2024 18:44:59 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Nikunj Kela <quic_nkela@...cinc.com>
Cc: konradybcio@...nel.org, herbert@...dor.apana.org.au, 
 cristian.marussi@....com, rui.zhang@...el.com, robimarko@...il.com, 
 andi.shyti@...nel.org, amitk@...nel.org, wim@...ux-watchdog.org, 
 iommu@...ts.linux.dev, thara.gopinath@...il.com, jassisinghbrar@...il.com, 
 linux-serial@...r.kernel.org, arm-scmi@...r.kernel.org, vkoul@...nel.org, 
 linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org, 
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
 sudeep.holla@....com, broonie@...nel.org, joro@...tes.org, 
 linux@...ck-us.net, viresh.kumar@...aro.org, krzk+dt@...nel.org, 
 linux-arm-msm@...r.kernel.org, linux-spi@...r.kernel.org, 
 conor+dt@...nel.org, lee@...nel.org, davem@...emloft.net, 
 linux-i2c@...r.kernel.org, quic_gurus@...cinc.com, quic_rjendra@...cinc.com, 
 linus.walleij@...aro.org, agross@...nel.org, bartosz.golaszewski@...aro.org, 
 rafael@...nel.org, robin.murphy@....com, quic_psodagud@...cinc.com, 
 linux-gpio@...r.kernel.org, andersson@...nel.org, will@...nel.org, 
 linux-pm@...r.kernel.org, Praveen Talari <quic_ptalari@...cinc.com>, 
 quic_tsoni@...cinc.com, tglx@...utronix.de, linux-crypto@...r.kernel.org, 
 kernel@...cinc.com, lukasz.luba@....com, quic_shazhuss@...cinc.com
Subject: Re: [PATCH 16/22] dt-bindings: qcom: geni-se: document support for
 SA8255P


On Wed, 28 Aug 2024 13:37:15 -0700, Nikunj Kela wrote:
> Add "qcom,sa8255p-geni-se-qup" compatible for representing QUP on
> SA8255p.
> 
> Clocks are being managed by the firmware VM and not required on
> SA8255p Linux VM hence removing it from required list.
> 
> CC: Praveen Talari <quic_ptalari@...cinc.com>
> Signed-off-by: Nikunj Kela <quic_nkela@...cinc.com>
> ---
>  .../bindings/soc/qcom/qcom,geni-se.yaml       | 47 +++++++++++++++++--
>  1 file changed, 43 insertions(+), 4 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@...000: i2c@...000:compatible:0: 'qcom,sa8255p-geni-i2c' is not one of ['qcom,geni-i2c', 'qcom,geni-i2c-master-hub']
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@...000: i2c@...000: 'clocks' is a required property
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@...000: i2c@...000: 'clock-names' is a required property
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@...000: i2c@...000: Unevaluated properties are not allowed ('compatible' was unexpected)
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@...000: serial@...000:compatible:0: 'qcom,sa8255p-geni-uart' is not one of ['qcom,geni-uart', 'qcom,geni-debug-uart']
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@...000: serial@...000:power-domains: [[4294967295, 4], [4294967295, 4]] is too long
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@...000: serial@...000: 'clocks' is a required property
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@...000: serial@...000: 'clock-names' is a required property
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@...000: serial@...000: Unevaluated properties are not allowed ('compatible', 'power-domain-names', 'power-domains' were unexpected)
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: /example-1/soc/geniqup@...000/i2c@...000: failed to match any schema with compatible: ['qcom,sa8255p-geni-i2c']
Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: /example-1/soc/geniqup@...000/serial@...000: failed to match any schema with compatible: ['qcom,sa8255p-geni-uart']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240828203721.2751904-17-quic_nkela@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Powered by blists - more mailing lists