linux-kernel - Re: [PATCH] ALSA: hda/realtek: Limit mic boost on Positivo DN50F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ttf5yxds.wl-tiwai@suse.de>
Date: Wed, 28 Aug 2024 08:28:15 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Edson Juliano Drosdeck <edson.drosdeck@...il.com>
Cc: tiwai@...e.com,
	perex@...ex.cz,
	kailang@...ltek.com,
	sbinding@...nsource.cirrus.com,
	simont@...nsource.cirrus.com,
	foss@...aariq.my.id,
	rf@...nsource.cirrus.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Edson Juliano Drosdeck <edson@...icorp.com>
Subject: Re: [PATCH] ALSA: hda/realtek: Limit mic boost on Positivo DN50F

On Tue, 27 Aug 2024 13:29:12 +0200,
Edson Juliano Drosdeck wrote:
> 
> The internal mic boost on the DN50F is too high. Fix this by applying the
> ALC269_FIXUP_LIMIT_INT_MIC_BOOST fixup to the machine to limit the gain.
> 
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@...il.com>
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index d022a25635f9..b6bd3903701e 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10767,6 +10767,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1d72, 0x1901, "RedmiBook 14", ALC256_FIXUP_ASUS_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1d72, 0x1945, "Redmi G", ALC256_FIXUP_ASUS_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1d72, 0x1947, "RedmiBook Air", ALC255_FIXUP_XIAOMI_HEADSET_MIC),
> +	SND_PCI_QUIRK(0x1e50, 0x7038, "Positivo DN50F", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x2782, 0x0214, "VAIO VJFE-CL", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x2782, 0x0232, "CHUWI CoreBook XPro", ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO),
>  	SND_PCI_QUIRK(0x2782, 0x1707, "Vaio VJFE-ADL", ALC298_FIXUP_SPK_VOLUME),

The table is sorted in PCI SSID order.  Could you try to put the new
entry at the right position and resubmit?


thanks,

Takashi