linux-kernel - Re: [PATCH] mmc : fix for check cqe halt.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y14hqhcg.fsf@gmail.com>
Date: Wed, 28 Aug 2024 12:11:51 +0530
From: Ritesh Harjani <ritesh.list@...il.com>
To: Seunghwan Baek <sh8267.baek@...sung.com>, linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org, ulf.hansson@...aro.org, quic_asutoshd@...cinc.com, adrian.hunter@...el.com
Cc: grant.jung@...sung.com, jt77.jang@...sung.com, junwoo80.lee@...sung.com, dh0421.hwang@...sung.com, jangsub.yi@...sung.com, sh043.lee@...sung.com, cw9316.lee@...sung.com, sh8267.baek@...sung.com, wkon.kim@...sung.com, stable@...r.kernel.org
Subject: Re: [PATCH] mmc : fix for check cqe halt.

Ritesh Harjani <ritesh.list@...il.com> writes:

> Seunghwan Baek <sh8267.baek@...sung.com> writes:
>
>> To check if mmc cqe is in halt state, need to check set/clear of CQHCI_HALT
>> bit. At this time, we need to check with &, not &&.
>>
>> Fixes: 0653300224a6 ("mmc: cqhci: rename cqhci.c to cqhci-core.c")

Correction. This should be: 
Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host")

Subject can be:
mmc: cqhci: Fix checking of CQHCI_HALT state

>> Cc: stable@...r.kernel.org
>> Signed-off-by: Seunghwan Baek <sh8267.baek@...sung.com>
>> ---
>>  drivers/mmc/host/cqhci-core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Thanks for fixing it!
> Small suggestion below. But this still looks good to me, so either ways- 
>
> Reviewed-by: Ritesh Harjani <ritesh.list@...il.com>

With above changes please feel free to add RVB.

-ritesh