linux-kernel - Re: [net-next v3 8/9] net: mvpp2: Convert to devm_clk_get_enabled() and devm_clk_get_optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVSz32c6qXYSX4YSfO5mo-30Jku3kgPyR3-PXBoQqex3g@mail.gmail.com>
Date: Wed, 28 Aug 2024 09:12:50 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Marcin Wojtas <marcin.s.wojtas@...il.com>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>, Yangtao Li <frank.li@...o.com>, 
	clement.leger@...tlin.com, andrew@...n.ch, f.fainelli@...il.com, 
	olteanv@...il.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, ulli.kroll@...glemail.com, linus.walleij@...aro.org, 
	linux@...linux.org.uk, alexandre.torgue@...s.st.com, joabreu@...opsys.com, 
	mcoquelin.stm32@...il.com, hkallweit1@...il.com, 
	u.kleine-koenig@...gutronix.de, jacob.e.keller@...el.com, 
	justinstitt@...gle.com, sd@...asysnail.net, horms@...nel.org, 
	linux-renesas-soc@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-stm32@...md-mailman.stormreply.com, 
	Maxime Chevallier <maxime.chevallier@...tlin.com>, 
	Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [net-next v3 8/9] net: mvpp2: Convert to devm_clk_get_enabled()
 and devm_clk_get_optional_enabled()

Hi Marcin,

On Wed, Aug 28, 2024 at 8:26 AM Marcin Wojtas <marcin.s.wojtas@...il.com> wrote:
> wt., 27 sie 2024 o 13:09 Jonathan Cameron
> <Jonathan.Cameron@...wei.com> napisał(a):
> > On Tue, 27 Aug 2024 03:57:11 -0600
> > Yangtao Li <frank.li@...o.com> wrote:
> > > Use devm_clk_get_enabled() and devm_clk_get_optional_enabled()
> > > to simplify code.
> > >
> > > Signed-off-by: Yangtao Li <frank.li@...o.com>
> > > Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> > > Tested-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> > > Suggested-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> > > Reviewed-by: Marcin Wojtas <marcin.s.wojtas@...il.com>
> >
> > >
> > > @@ -7745,12 +7710,6 @@ static void mvpp2_remove(struct platform_device *pdev)
> > >
> > >       if (!dev_of_node(&pdev->dev))
> > >               return;
> >
> > Given this makes no difference any more, drop the above dev_of_node() check.
>
> This check is to not execute the clk-related code when booting with
> ACPI. It should remain as-is, unless the new devm_clk_get* api is
> capable of not exploding in non-DT case. Can you confirm?

As per the removals below, there is no code left in this function after
the check (i.e. the "else" part became empty).

> > > -
> > > -     clk_disable_unprepare(priv->axi_clk);
> > > -     clk_disable_unprepare(priv->mg_core_clk);
> > > -     clk_disable_unprepare(priv->mg_clk);
> > > -     clk_disable_unprepare(priv->pp_clk);
> > > -     clk_disable_unprepare(priv->gop_clk);
> > >  }

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds