linux-kernel - Re: [PATCH v1 10/12] ARM: dts: microchip: sam9x60: Add clock properties to OTPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240828-paddling-manhole-0946de0f3670@thorsis.com>
Date: Wed, 28 Aug 2024 10:22:52 +0200
From: Alexander Dahl <ada@...rsis.com>
To: claudiu beznea <claudiu.beznea@...on.dev>
Cc: Alexander Dahl <ada@...rsis.com>,
	Christian Melki <christian.melki@...ata.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>
Subject: Re: [PATCH v1 10/12] ARM: dts: microchip: sam9x60: Add clock
 properties to OTPC

Hello Claudiu,

Am Sat, Aug 24, 2024 at 06:57:23PM +0300 schrieb claudiu beznea:
> 
> 
> On 21.08.2024 13:59, Alexander Dahl wrote:
> > This will allow to enable the main RC Oscillator from
> > nvmem_microchip_otpc driver.
> > 
> > Signed-off-by: Alexander Dahl <ada@...rsis.com>
> > ---
> > 
> > Notes:
> >     This requires some DT bindings update, right?
> 
> Yes

Okay, I suspected that already.

This raises the question if the main rc osc clock should be mandatory
for SAMA7G5 too, or if SAM9X60 and SAMA7G5 should be handled
differently with regard to that clock?  Affects both binding and
driver then, see NOTE in patch 11, which is directly related to that
question.

> 
> > 
> >  arch/arm/boot/dts/microchip/sam9x60.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/microchip/sam9x60.dtsi b/arch/arm/boot/dts/microchip/sam9x60.dtsi
> > index 2159a6817f44..4f0651b8cb60 100644
> > --- a/arch/arm/boot/dts/microchip/sam9x60.dtsi
> > +++ b/arch/arm/boot/dts/microchip/sam9x60.dtsi
> > @@ -162,6 +162,8 @@ otpc: efuse@...00000 {
> >  			reg = <0xeff00000 0xec>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> > +			clocks = <&pmc PMC_TYPE_CORE 11>;
> > +			clock-names = "main_rc_osc";
> 
> And this should be squashed w/ patch 05/12.

Okay, this may require patch reordering, we'll see.

Greets
Alex

> 
> >  		};
> >  
> >  		apb {