[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zs7i4PSQQEI0tHN6@calendula>
Date: Wed, 28 Aug 2024 10:42:08 +0200
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: kadlec@...filter.org, roopa@...dia.com, razor@...ckwall.org,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, dsahern@...nel.org, krzk@...nel.org,
netfilter-devel@...r.kernel.org, coreteam@...filter.org,
bridge@...ts.linux.dev, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 4/5] netfilter: iptables: Use kmemdup_array()
instead of kmemdup() for multiple allocation
On Wed, Aug 28, 2024 at 03:10:03PM +0800, Jinjie Ruan wrote:
> Let the kmemdup_array() take care about multiplication and possible
> overflows.
No patch for net/ipv6/netfilter/ip6_tables.c?
We have yet another code copy & paste there.
BTW, could you collapse all these patches for netfilter in one single
patch?
Thanks.
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
> net/ipv4/netfilter/ip_tables.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c
> index fe89a056eb06..096bfef472b1 100644
> --- a/net/ipv4/netfilter/ip_tables.c
> +++ b/net/ipv4/netfilter/ip_tables.c
> @@ -1767,7 +1767,7 @@ int ipt_register_table(struct net *net, const struct xt_table *table,
> goto out_free;
> }
>
> - ops = kmemdup(template_ops, sizeof(*ops) * num_ops, GFP_KERNEL);
> + ops = kmemdup_array(template_ops, num_ops, sizeof(*ops), GFP_KERNEL);
> if (!ops) {
> ret = -ENOMEM;
> goto out_free;
> --
> 2.34.1
>
>
Powered by blists - more mailing lists