linux-kernel - Re: [syzbot] [net?] general protection fault in phy_start_cable_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_85866689832EDE6ED8CC92A7DD46FD12E406@qq.com>
Date: Wed, 28 Aug 2024 09:34:49 +0800
From: Edward Adam Davis <eadavis@...com>
To: syzbot+5cf270e2069645b6bd2c@...kaller.appspotmail.com
Cc: linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [net?] general protection fault in phy_start_cable_test_tdr

There is a logical error in checking phydev

#syz test: net-next main

diff --git a/net/ethtool/cabletest.c b/net/ethtool/cabletest.c
index 3a91b65c1f9a..2fe5951b8e45 100644
--- a/net/ethtool/cabletest.c
+++ b/net/ethtool/cabletest.c
@@ -342,7 +342,7 @@ int ethnl_act_cable_test_tdr(struct sk_buff *skb, struct genl_info *info)
 	phydev = ethnl_req_get_phydev(&req_info,
 				      tb[ETHTOOL_A_CABLE_TEST_TDR_HEADER],
 				      info->extack);
-	if (!IS_ERR_OR_NULL(phydev)) {
+	if (IS_ERR_OR_NULL(phydev)) {
 		ret = -EOPNOTSUPP;
 		goto out_dev_put;
 	}