linux-kernel - Re: [PATCH 2/2] remoteproc: qcom: pas: Add QCS8300 remoteproc support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4340f1d1-b049-4368-8227-b6400ae0cbce@quicinc.com>
Date: Wed, 28 Aug 2024 17:12:11 +0800
From: "Aiqun Yu (Maria)" <quic_aiquny@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Jingyi Wang
	<quic_jingyw@...cinc.com>
CC: <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>,
        <andersson@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <mathieu.poirier@...aro.org>,
        <bartosz.golaszewski@...aro.or>, <quic_tingweiz@...cinc.com>,
        <quic_tengfan@...cinc.com>, Xin Liu <quic_liuxin@...cinc.com>
Subject: Re: [PATCH 2/2] remoteproc: qcom: pas: Add QCS8300 remoteproc support



On 8/28/2024 3:24 PM, Krzysztof Kozlowski wrote:
> On Wed, Aug 28, 2024 at 11:05:11AM +0800, Jingyi Wang wrote:
>> Add support for PIL loading on ADSP, CDSP and GPDSP on QCS8300
>> platform.
>>
>> Co-developed-by: Xin Liu <quic_liuxin@...cinc.com>
>> Signed-off-by: Xin Liu <quic_liuxin@...cinc.com>
>> Signed-off-by: Jingyi Wang <quic_jingyw@...cinc.com>
>> ---
>>  drivers/remoteproc/qcom_q6v5_pas.c | 55 ++++++++++++++++++++++++++++++
>>  1 file changed, 55 insertions(+)
>>
>> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
>> index ef82835e98a4..368aa9cc0051 100644
>> --- a/drivers/remoteproc/qcom_q6v5_pas.c
>> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
>> @@ -857,6 +857,58 @@ static const struct adsp_data sdm845_adsp_resource_init = {
>>  	.ssctl_id = 0x14,
>>  };
>>  
>> +static const struct adsp_data qcs8300_adsp_resource = {
>> +	.crash_reason_smem = 423,
> 
> You just duplicate stuff. This is EXACTLY the same as SA8775p.

Agreed with you. Offline checked with Jingyi, she will remove the
creation and use sa8775p_adsp_resource directly.

Will it be ok to put the second patchset here along with the qcs8300
base dt changes together?
> 
> NAK.
> 
> Best regards,
> Krzysztof
> 

-- 
Thx and BRs,
Aiqun(Maria) Yu