[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <94899c78-97e3-230a-a7eb-d4d448d9fa75@amd.com>
Date: Wed, 28 Aug 2024 15:46:23 +0530
From: "Nikunj A. Dadhania" <nikunj@....com>
To: Borislav Petkov <bp@...en8.de>
Cc: linux-kernel@...r.kernel.org, thomas.lendacky@....com, x86@...nel.org,
kvm@...r.kernel.org, mingo@...hat.com, tglx@...utronix.de,
dave.hansen@...ux.intel.com, pgonda@...gle.com, seanjc@...gle.com,
pbonzini@...hat.com
Subject: Re: [PATCH v11 06/20] x86/sev: Handle failures from snp_init()
On 8/28/2024 3:19 PM, Borislav Petkov wrote:
> On Wed, Aug 28, 2024 at 10:17:57AM +0530, Nikunj A. Dadhania wrote:
>> + if ((snp && !snp_enabled) ||
>> + (!snp && snp_enabled))
>> snp_abort();
>
> And which boolean function is that?
Ah.. missed that.
> /*
> - * The SEV-SNP CC blob should be present and parsing CC blob should
> - * succeed when SEV-SNP is enabled.
> + * Any discrepancies between the presence of a CC blob and SNP
> + * enablement abort the guest.
> */
> - if (!snp && (msr & MSR_AMD64_SEV_SNP_ENABLED))
> + if (snp_en ^ (msr & MSR_AMD64_SEV_SNP_ENABLED))
> snp_abort();
>
> /* Check if memory encryption is enabled */
>
Do you want me to send the patch again with above change?
Regards
Nikunj
Powered by blists - more mailing lists