linux-kernel - Re: [PATCH 03/16] arm64: dts: qcom: sc7180: change labels to lower-case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ab35d34-0a5f-44ac-9621-18067fd23558@linaro.org>
Date: Wed, 28 Aug 2024 13:13:20 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Konrad Dybcio <konradybcio@...il.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, cros-qcom-dts-watchers@...omium.org
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/16] arm64: dts: qcom: sc7180: change labels to
 lower-case

On 28/08/2024 12:53, Konrad Dybcio wrote:
> On 28.08.2024 9:17 AM, Krzysztof Kozlowski wrote:
>> DTS coding style expects labels to be lowercase.  No functional impact.
>> Verified with comparing decompiled DTB (dtx_diff and fdtdump+diff).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sc7180-firmware-tfa.dtsi  |  84 ++---
>>  .../arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi |   8 +-
>>  .../boot/dts/qcom/sc7180-trogdor-homestar.dtsi     |   8 +-
>>  .../boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi  |   8 +-
>>  arch/arm64/boot/dts/qcom/sc7180.dtsi               | 344 ++++++++++-----------
>>  arch/arm64/boot/dts/qcom/sm7125.dtsi               |  16 +-
>>  6 files changed, 234 insertions(+), 234 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-firmware-tfa.dtsi b/arch/arm64/boot/dts/qcom/sc7180-firmware-tfa.dtsi
>> index ee35a454dbf6..f362b6b436ce 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180-firmware-tfa.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180-firmware-tfa.dtsi
>> @@ -6,82 +6,82 @@
>>   * by Qualcomm firmware.
>>   */
>>  
>> -&CPU0 {
>> +&cpu0 {
>>  	/delete-property/ power-domains;
>>  	/delete-property/ power-domain-names;
>>  
>> -	cpu-idle-states = <&LITTLE_CPU_SLEEP_0
>> -			   &LITTLE_CPU_SLEEP_1
>> -			   &CLUSTER_SLEEP_0>;
>> +	cpu-idle-states = <&LITTLE_cpu_sleep_0
>> +			   &LITTLE_cpu_sleep_1
>> +			   &cluster_sleep_0>;
> 
> I suppose this wasn't intended

Yeah, I need to improve the pattern. Thanks for finding this.

Best regards,
Krzysztof