linux-kernel - [PATCH] x86/mm/tlb: Correct the comments in flush_tlb_mm_range() and arch_tlbbatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240828020741.99869-1-yuntao.wang@linux.dev>
Date: Wed, 28 Aug 2024 10:07:41 +0800
From: Yuntao Wang <yuntao.wang@...ux.dev>
To: linux-kernel@...r.kernel.org,
	x86@...nel.org
Cc: Dave Hansen <dave.hansen@...ux.intel.com>,
	Andy Lutomirski <luto@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Borislav Petkov <bp@...en8.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Nadav Amit <nadav.amit@...il.com>,
	Yuntao Wang <yuntao.wang@...ux.dev>
Subject: [PATCH] x86/mm/tlb: Correct the comments in flush_tlb_mm_range() and arch_tlbbatch_flush()

Commit 4c1ba3923e6c ("x86/mm/tlb: Unify flush_tlb_func_local() and
flush_tlb_func_remote()") unified flush_tlb_func_local() and
flush_tlb_func_remote() into flush_tlb_func(). However, in commit
4ce94eabac16 ("x86/mm/tlb: Flush remote and local TLBs concurrently"),
the newly introduced comments still refer to flush_tlb_func_local() when
they should use flush_tlb_func().

Correct these comments.

Signed-off-by: Yuntao Wang <yuntao.wang@...ux.dev>
---
 arch/x86/mm/tlb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 44ac64f3a047..8b874ec90536 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -1021,7 +1021,7 @@ void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
 	/*
 	 * flush_tlb_multi() is not optimized for the common case in which only
 	 * a local TLB flush is needed. Optimize this use-case by calling
-	 * flush_tlb_func_local() directly in this case.
+	 * flush_tlb_func() directly in this case.
 	 */
 	if (cpumask_any_but(mm_cpumask(mm), cpu) < nr_cpu_ids) {
 		flush_tlb_multi(mm_cpumask(mm), info);
@@ -1254,7 +1254,7 @@ void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch)
 	/*
 	 * flush_tlb_multi() is not optimized for the common case in which only
 	 * a local TLB flush is needed. Optimize this use-case by calling
-	 * flush_tlb_func_local() directly in this case.
+	 * flush_tlb_func() directly in this case.
 	 */
 	if (cpumask_any_but(&batch->cpumask, cpu) < nr_cpu_ids) {
 		flush_tlb_multi(&batch->cpumask, info);
-- 
2.46.0