linux-kernel - Re: [GIT PULL] Btrfs fixes for 6.11-rc6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL3q7H5L9ebGLyPkVFOtG7sEfAj7f17e6uzH2g7s5MUc59FAsQ@mail.gmail.com>
Date: Wed, 28 Aug 2024 12:50:22 +0100
From: Filipe Manana <fdmanana@...nel.org>
To: David Sterba <dsterba@...e.com>
Cc: torvalds@...ux-foundation.org, linux-btrfs@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] Btrfs fixes for 6.11-rc6

On Wed, Aug 28, 2024 at 12:23 PM David Sterba <dsterba@...e.com> wrote:
>
> Hi,
>
> a few more misc fixes. Please pull, thanks.
>
> - fix use-after-free when submitting bios for read, after an error and
>   partially submitted bio the original one is freed while it can be still be
>   accessed again
>
> - fix fstests case btrfs/301, with enabled quotas wait for delayed iputs when
>   flushing delalloc
>
> - fix regression in periodic block group reclaim, an unitialized value can be
>   returned if there are no block groups to reclaim

There's some confusion here.

First, it's not a regression because the uninitialized return value
has been there since periodic block group reclaim was introduced.

Secondly, and more important, is that it doesn't cause any problem
because the only caller of the function ignores its return value.

So this is effectively more of a cleanup than anything else, and could
have waited for the next merge window.
I see you also added a Fixes tag to the changelog, which will trigger
stable backports.

Unless there are compiler versions or static analysis tools that
complain with warnings, it will be just overhead to backport to stable
releases.

Thanks.

>
> - fix build warning (-Wmaybe-uninitialized)
>
> ----------------------------------------------------------------
> The following changes since commit 534f7eff9239c1b0af852fc33f5af2b62c00eddf:
>
>   btrfs: only enable extent map shrinker for DEBUG builds (2024-08-16 21:22:39 +0200)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git tags/for-6.11-rc5-tag
>
> for you to fetch changes up to ecb54277cb63c273e8d74272e5b9bfd80c2185d9:
>
>   btrfs: fix uninitialized return value from btrfs_reclaim_sweep() (2024-08-27 16:42:09 +0200)
>
> ----------------------------------------------------------------
> David Sterba (1):
>       btrfs: initialize last_extent_end to fix -Wmaybe-uninitialized warning in extent_fiemap()
>
> Filipe Manana (1):
>       btrfs: fix uninitialized return value from btrfs_reclaim_sweep()
>
> Josef Bacik (1):
>       btrfs: run delayed iputs when flushing delalloc
>
> Qu Wenruo (1):
>       btrfs: fix a use-after-free when hitting errors inside btrfs_submit_chunk()
>
>  fs/btrfs/bio.c        | 26 ++++++++++++++++++--------
>  fs/btrfs/fiemap.c     |  2 +-
>  fs/btrfs/qgroup.c     |  2 ++
>  fs/btrfs/space-info.c | 17 +++++------------
>  fs/btrfs/space-info.h |  2 +-
>  5 files changed, 27 insertions(+), 22 deletions(-)
>