linux-kernel - Re: [PATCH v1] rtc: rtc-asm9260: Switch to use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240828-tractor-dig-7bf21a1ef549@thorsis.com>
Date: Wed, 28 Aug 2024 14:35:06 +0200
From: Alexander Dahl <ada@...rsis.com>
To: Yang Ruibin <11162571@...o.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	linux-arm-kernel@...ts.infradead.org, linux-rtc@...r.kernel.org,
	linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] rtc: rtc-asm9260: Switch to use dev_err_probe()

Hello,

Am Wed, Aug 28, 2024 at 08:25:07PM +0800 schrieb Yang Ruibin:
> use dev_err_probe() instead of dev_err() to simplify the error path and
> standardize the format of the error code.
> 
> Signed-off-by: Yang Ruibin <11162571@...o.com>
> ---
>  drivers/rtc/rtc-asm9260.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-asm9260.c b/drivers/rtc/rtc-asm9260.c
> index a83b47e0d..2b7058ebb 100644
> --- a/drivers/rtc/rtc-asm9260.c
> +++ b/drivers/rtc/rtc-asm9260.c
> @@ -268,10 +268,8 @@ static int asm9260_rtc_probe(struct platform_device *pdev)
>  		return PTR_ERR(priv->clk);
>  
>  	ret = clk_prepare_enable(priv->clk);
> -	if (ret) {
> -		dev_err(dev, "Failed to enable clk!\n");
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(dev, ret, "Failed to prepare clk!\n");

This changes the error message from "failed to enable" to "failed to
prepare", which is not what the commit message says.  However
technically clk_prepare_enable() does both, so maybe a different text
would match better?

Greets
Alex

>  
>  	ccr = ioread32(priv->iobase + HW_CCR);
>  	/* if dev is not enabled, reset it */
> -- 
> 2.34.1
> 
>