linux-kernel - RE: [PATCH] firmware: arm_scmi: imx: add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB845929FBE17BEBAFE9B9A04288952@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Wed, 28 Aug 2024 12:43:12 +0000
From: Peng Fan <peng.fan@....com>
To: Sudeep Holla <sudeep.holla@....com>
CC: "Peng Fan (OSS)" <peng.fan@....nxp.com>, "cristian.marussi@....com"
	<cristian.marussi@....com>, "shawnguo@...nel.org" <shawnguo@...nel.org>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "festevam@...il.com" <festevam@...il.com>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH] firmware: arm_scmi: imx: add MODULE_LICENSE/DESCRIPTION

> Subject: Re: [PATCH] firmware: arm_scmi: imx: add
> MODULE_LICENSE/DESCRIPTION
> 
> On Wed, Aug 28, 2024 at 05:17:27AM +0000, Peng Fan wrote:
> > > Subject: [PATCH] firmware: arm_scmi: imx: add
> > > MODULE_LICENSE/DESCRIPTION
> > >
> > > From: Peng Fan <peng.fan@....com>
> > >
> > > Add missing MODULE_LICENSE and MODULE_DESCRIPTION
> > >
> > > Signed-off-by: Peng Fan <peng.fan@....com>
> > > ---
> > >
> > > Hi Sudeep,
> > >  My bad for not build this as module. If you need me fix the
> > > previous patchset,  please let me know.
> > > Thanks,
> > > Peng.
> > >
> > >  drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c  | 3 +++
> > > drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 3 +++
> > >  2 files changed, 6 insertions(+)
> > >
> > > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > > b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > > index 0df7ca135c34..ad8734d2aeab 100644
> > > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > > @@ -377,3 +377,6 @@ static const struct scmi_protocol
> scmi_imx_bbm =
> > > {
> > >  	.sub_vendor_id = "IMX",
> > >  };
> > >  module_scmi_protocol(scmi_imx_bbm);
> > > +
> > > +MODULE_DESCRIPTION("i.MX SCMI BBM driver");
> > > MODULE_LICENSE("GPL");
> > > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > > b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > > index 9ee2d204d607..1d339cfa6ecf 100644
> > > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > > @@ -313,3 +313,6 @@ static const struct scmi_protocol
> scmi_imx_misc
> > > = {
> > >  	.sub_vendor_id = "IMX",
> > >  };
> > >  module_scmi_protocol(scmi_imx_misc);
> > > +
> > > +MODULE_DESCRIPTION("i.MX SCMI BBM driver");
> >
> > Just find this Typo. BBM->MISC.
> >
> 
> I was about to ask the same. Please take time needed to push out any
> patch, no point in rushing and churning unnecessarily like this.
> 
> Anyways, I did hit the issue last night and fixed it locally but didn't
> push out as it was late for today's next. Please check if
> https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git/commit/?id=for-next/scmi/updates

Your fix is good. Thanks for helping on this issue. I will take care
next time.

Thanks,
Peng.

> 
> --
> Regards,
> Sudeep