[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zs8iGy8zLG2zs34J@smile.fi.intel.com>
Date: Wed, 28 Aug 2024 16:11:55 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Stephen Boyd <sboyd@...nel.org>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
Michael Turquette <mturquette@...libre.com>
Subject: Re: [PATCH v1 1/2] clk: x86: lpss-atom: Use predefined constants
from units.h
On Tue, Aug 27, 2024 at 05:21:00PM -0700, Stephen Boyd wrote:
> Quoting Andy Shevchenko (2024-08-22 09:14:07)
...
> > static int lpss_atom_clk_probe(struct platform_device *pdev)
> > {
> > struct lpss_clk_data *drvdata;
> > struct clk *clk;
> > + u32 rate;
>
> Do we need a local variable?
Hmm... The idea was to allow retrieving this via device properties, that's why
a separate variable, but that patch wasn't included here.
Nevertheless, despite above the separate variable makes code a bit better to
read as we can see what is this value about.
> > drvdata = devm_kzalloc(&pdev->dev, sizeof(*drvdata), GFP_KERNEL);
> > if (!drvdata)
> > return -ENOMEM;
> >
> > + /* Default frequency is 100MHz */
> > + rate = 100 * HZ_PER_MHZ;
> > +
> > /* LPSS free running clock */
> > drvdata->name = "lpss_clk";
> > - clk = clk_register_fixed_rate(&pdev->dev, drvdata->name, NULL,
> > - 0, 100000000);
> > + clk = clk_register_fixed_rate(&pdev->dev, drvdata->name, NULL, 0, rate);
>
> This should be a one line patch.
I don't get this. You mean the entire thingy?
It's possible, but as I mentioned above there is a rationale for making it with
a temporary variable.
> > if (IS_ERR(clk))
> > return PTR_ERR(clk);
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists