linux-kernel - Re: [PATCH v13 3/5] dt-bindings: net: wireless: brcm4329-fmac: change properties enum structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd19fd84-2595-41d0-b9cc-7e2c5e62f1c5@wesion.com>
Date: Wed, 28 Aug 2024 21:20:27 +0800
From: Jacobe Zang <jacobe.zang@...ion.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Kalle Valo <kvalo@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, van Spriel <arend@...adcom.com>,
 Arend van Spriel <arend.vanspriel@...adcom.com>
Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 brcm80211@...ts.linux.dev, brcm80211-dev-list.pdl@...adcom.com
Subject: Re: [PATCH v13 3/5] dt-bindings: net: wireless: brcm4329-fmac: change
 properties enum structure

On 2024/8/28 21:04, Krzysztof Kozlowski wrote:
> On 28/08/2024 10:49, Jacobe Zang wrote:
>> Add "brcm,bcm4329-fmac" as fallback compatible for wireless devices that
>> used PCI ID based compatible. So that can pass the compatible check in
>> driver.
> 
> Driver? Why this has to pass compatible check?
> 
> I think I asked to provide proper rationale based on hardware... if not,
> then let me ask here: Please provide proper rationale explaining how
> this hardware is compatible, especially considering these are entirely
> different buses (SDIO and PCI!).
> 
> It feels you patch up bindings and DTS, because of buggy driver. Sorry
> no, fix the driver.
> 

All right. Anyway after discussion in the other series, this patch 
should be dropped, and driver also need to fix.

-- 
Best Regards
Jacobe