linux-kernel - Re: [PATCHv6 2/4] x86/tdx: Rename tdx_parse_tdinfo() to tdx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e042faa6-91be-49bb-ae59-e87792756fa4@suse.com>
Date: Wed, 28 Aug 2024 16:53:57 +0300
From: Nikolay Borisov <nik.borisov@...e.com>
To: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, x86@...nel.org,
 "H. Peter Anvin" <hpa@...or.com>
Cc: linux-coco@...ts.linux.dev, linux-kernel@...r.kernel.org,
 Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>,
 Kai Huang <kai.huang@...el.com>, stable@...r.kernel.org
Subject: Re: [PATCHv6 2/4] x86/tdx: Rename tdx_parse_tdinfo() to tdx_setup()

On 28.08.24 г. 12:35 ч., Kirill A. Shutemov wrote:
> Rename tdx_parse_tdinfo() to tdx_setup() and move setting NOTIFY_ENABLES
> there.
> 
> The function will be extended to adjust TD configuration.

<offtopic>
Since this deals with renaming, I think it will make sense to rename 
tdx_early_init() to tdx_guest_init/tdx_guest_early_init as it becomes 
confusing as to which parts of the TDX pertain to the host and which to 
the guest. Right now we only have the guest portions under 
arch/x86/coco/tdx but when the kvm/vmx stuff land things will become 
somewhat messy..
</offtopic>

<snip>