linux-kernel - Re: [PATCH -next 1/3] media: v4l2-subdev: enable module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c219682-833e-41d6-8708-044b89f9d591@huawei.com>
Date: Thu, 29 Aug 2024 21:03:43 +0800
From: "liaochen (A)" <liaochen4@...wei.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>, Biju Das
	<biju.das.jz@...renesas.com>
CC: "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "thierry.reding@...il.com" <thierry.reding@...il.com>,
	"jonathanh@...dia.com" <jonathanh@...dia.com>, "jacopo@...ndi.org"
	<jacopo@...ndi.org>, "sakari.ailus@...ux.intel.com"
	<sakari.ailus@...ux.intel.com>, "tomi.valkeinen@...asonboard.com"
	<tomi.valkeinen@...asonboard.com>
Subject: Re: [PATCH -next 1/3] media: v4l2-subdev: enable module autoloading

On 2024/8/29 17:45, Laurent Pinchart wrote:
> On Thu, Aug 29, 2024 at 08:27:06AM +0000, Biju Das wrote:
>> Hi Liao Chen,
>> On Thursday, August 29, 2024 8:54 AM, Liao Chen wrote:
>>> Subject: [PATCH -next 1/3] media: v4l2-subdev: enable module autoloading
>>
>> Commit header is wrong.
> 
> Indeed, it should be
> 
> media: i2c: mt9v111: Enable module autoloading
> 
>>> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from
>>> of_device_id table.
> 
> Please also reflow the commit message to 72 columns. With those issues
> fixed,
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
>>>
>>> Signed-off-by: Liao Chen <liaochen4@...wei.com>
>>> ---
>>>   drivers/media/i2c/mt9v111.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c index
>>> b0b98ed3c150..b6a2623798c5 100644
>>> --- a/drivers/media/i2c/mt9v111.c
>>> +++ b/drivers/media/i2c/mt9v111.c
>>> @@ -1265,6 +1265,7 @@ static const struct of_device_id mt9v111_of_match[] = {
>>>   	{ .compatible = "aptina,mt9v111", },
>>>   	{ /* sentinel */ },
>>
>> Nit: Comma can be dropped from terminator entry as a separate patch.
>>
>> Cheers,
>> Biju
>>
>>>   };
>>> +MODULE_DEVICE_TABLE(of, mt9v111_of_match);
>>>
>>>   static struct i2c_driver mt9v111_driver = {
>>>   	.driver = {
> 
Thanks for pointing out, just sent a patch series with these issues fixed.

Thanks,
Chen