linux-kernel - RE: [PATCH -next 2/2] media: i2c: mt9v111: Drop redundant comma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB11346E2797E874A37FBD3D62986962@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Thu, 29 Aug 2024 13:05:30 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Liao Chen <liaochen4@...wei.com>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
	"jacopo@...ndi.org" <jacopo@...ndi.org>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "laurent.pinchart@...asonboard.com"
	<laurent.pinchart@...asonboard.com>
Subject: RE: [PATCH -next 2/2] media: i2c: mt9v111: Drop redundant comma

Hi Liao Chen,

> -----Original Message-----
> From: Liao Chen <liaochen4@...wei.com>
> Sent: Thursday, August 29, 2024 1:52 PM
> Subject: [PATCH -next 2/2] media: i2c: mt9v111: Drop redundant comma
> 
> Drop the redundant comma from mt9v111_of_match array to make the code clean.

LGTM.

Reviewed-by: Biju Das <biju.das.jz@...renesas.com>

Actually, Removing the trailing comma in the terminator entry for the ID table
making code robust against (theoretical) misrebases or other similar things
where the new entry goes _after_ the termination without the compiler noticing."


> 
> Signed-off-by: Liao Chen <liaochen4@...wei.com>
> ---
>  drivers/media/i2c/mt9v111.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c index
> b6a2623798c5..723fe138e7bc 100644
> --- a/drivers/media/i2c/mt9v111.c
> +++ b/drivers/media/i2c/mt9v111.c
> @@ -1263,7 +1263,7 @@ static void mt9v111_remove(struct i2c_client *client)
> 
>  static const struct of_device_id mt9v111_of_match[] = {
>  	{ .compatible = "aptina,mt9v111", },
> -	{ /* sentinel */ },
> +	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, mt9v111_of_match);
> 
> --
> 2.34.1