linux-kernel - Re: [PATCH v2] usb: xHCI: add XHCI_RESET_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4a26f1ef-9264-667c-faa1-33a7ae69b473@huawei.com>
Date: Thu, 29 Aug 2024 22:16:33 +0800
From: Zenghui Yu <yuzenghui@...wei.com>
To: WangYuli <wangyuli@...ontech.com>
CC: <mathias.nyman@...el.com>, <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-pci@...r.kernel.org>, <guanwentao@...ontech.com>, Chen Baozi
	<chenbaozi@...tium.com.cn>, Wang Zhimin <wangzhimin1179@...tium.com.cn>, Chen
 Zhenhua <chenzhenhua@...tium.com.cn>, Wang Yinfeng
	<wangyinfeng@...tium.com.cn>, Jiakun Shuai <shuaijiakun1288@...tium.com.cn>
Subject: Re: [PATCH v2] usb: xHCI: add XHCI_RESET_ON_RESUME quirk for Phytium
 xHCI host

On 2024/8/29 17:50, WangYuli wrote:
> The resume operation of Phytium Px210 xHCI host would failed
> to restore state. Use the XHCI_RESET_ON_RESUME quirk to skip
> it and reset the controller after resume.
> 
> Co-developed-by: Chen Baozi <chenbaozi@...tium.com.cn>
> Signed-off-by: Chen Baozi <chenbaozi@...tium.com.cn>
> Co-developed-by: Wang Zhimin <wangzhimin1179@...tium.com.cn>
> Signed-off-by: Wang Zhimin <wangzhimin1179@...tium.com.cn>
> Co-developed-by: Chen Zhenhua <chenzhenhua@...tium.com.cn>
> Signed-off-by: Chen Zhenhua <chenzhenhua@...tium.com.cn>
> Co-developed-by: Wang Yinfeng <wangyinfeng@...tium.com.cn>
> Signed-off-by: Wang Yinfeng <wangyinfeng@...tium.com.cn>
> Co-developed-by: Jiakun Shuai <shuaijiakun1288@...tium.com.cn>
> Signed-off-by: Jiakun Shuai <shuaijiakun1288@...tium.com.cn>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
> ---

You should add the change log for a v2 patch.

>  drivers/usb/host/xhci-pci.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index b5705ed01d83..fabae8420ce9 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -55,6 +55,9 @@
>  #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI		0x51ed
>  #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_PCH_XHCI	0x54ed
>  
> +#define PCI_VENDOR_ID_PHYTIUM		0x1db7
> +#define PCI_DEVICE_ID_PHYTIUM_XHCI			0xdc27
> +
>  /* Thunderbolt */
>  #define PCI_DEVICE_ID_INTEL_MAPLE_RIDGE_XHCI		0x1138
>  #define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_2C_XHCI	0x15b5
> @@ -407,6 +410,10 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>  	if (pdev->vendor == PCI_VENDOR_ID_VIA)
>  		xhci->quirks |= XHCI_RESET_ON_RESUME;
>  
> +	if (pdev->vendor == PCI_VENDOR_ID_PHYTIUM ||

Shouldn't this be a '&&'?

> +	    pdev->device == PCI_DEVICE_ID_PHYTIUM_XHCI)
> +		xhci->quirks |= XHCI_RESET_ON_RESUME;
> +
>  	/* See https://bugzilla.kernel.org/show_bug.cgi?id=79511 */
>  	if (pdev->vendor == PCI_VENDOR_ID_VIA &&
>  			pdev->device == 0x3432)
>