linux-kernel - Re: [PATCH 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240829142226.GEZtCEIjD3wW6OowIs@fat_crate.local>
Date: Thu, 29 Aug 2024 16:22:26 +0200
From: Borislav Petkov <bp@...en8.de>
To: Pavan Kumar Paluri <papaluri@....com>
Cc: linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Eric Van Tassell <Eric.VanTassell@....com>,
	Tom Lendacky <thomas.lendacky@....com>,
	Ashish Kalra <ashish.kalra@....com>,
	Michael Roth <michael.roth@....com>,
	Brijesh Singh <brijesh.singh@....com>,
	"H . Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 1/2] x86, KVM:SVM: Move sev specific parsing into
 arch/x86/virt/svm

On Thu, Aug 29, 2024 at 03:24:38PM +0200, Borislav Petkov wrote:
> On Thu, Aug 01, 2024 at 03:56:37PM -0500, Pavan Kumar Paluri wrote:
> > +#include <linux/memblock.h>
> 
> What's the idea of adding some random include here?
> 
> Does this file use memblock?
> 
> I don't think so.
> 
> You need to resolve include visibility by including the headers where you need
> them:

And with this applied, your next patch needs includes too.

Please include only those headers into sev/cmdline.c which supply the
facilities you're using. IOW, include only those headers and only into those
files which need the respective facilities.

This needs to be done right because otherwise we have an include hell and some
poor moron gets to mop up after you in the future.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette