linux-kernel - Re: [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <744af115-3cfe-4d3a-9bf7-e6ac0cd12378@microchip.com>
Date: Thu, 29 Aug 2024 16:42:01 +0200
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>, Dharma Balasubiramani
	<dharma.b@...rochip.com>
CC: Michael Turquette <mturquette@...libre.com>, Stephen Boyd
	<sboyd@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Claudiu Beznea
	<claudiu.beznea@...on.dev>, <linux-clk@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string

Alexandre,

On 29/08/2024 at 16:10, Alexandre Belloni wrote:
> On 29/08/2024 15:08:45+0530, Dharma Balasubiramani wrote:
>> Add the `microchip,sama7d65-pmc` compatible string to the existing binding,
>> since the SAMA7D65 PMC shares the same properties and clock requirements
>> as the SAMA7G5.
> 
> Shouldn't you rather use a fallback if you currently have no driver
> change?

The clock/pmc driver is (will be) different. Only the binding of the PMC 
uses the same properties and clocks specification as our recent SoCs (so 
can be added to the "enum").

Regards,
   Nicolas

>> Signed-off-by: Dharma Balasubiramani <dharma.b@...rochip.com>
>> ---
>>   Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> index c9eb60776b4d..885d47dd5724 100644
>> --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> @@ -43,6 +43,7 @@ properties:
>>                 - atmel,sama5d4-pmc
>>                 - microchip,sam9x60-pmc
>>                 - microchip,sam9x7-pmc
>> +              - microchip,sama7d65-pmc
>>                 - microchip,sama7g5-pmc
>>             - const: syscon
>>
>> @@ -90,6 +91,7 @@ allOf:
>>               enum:
>>                 - microchip,sam9x60-pmc
>>                 - microchip,sam9x7-pmc
>> +              - microchip,sama7d65-pmc
>>                 - microchip,sama7g5-pmc
>>       then:
>>         properties:
>>
>> ---
>> base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e
>> change-id: 20240829-sama7d65-next-a91d089b56a3
>>
>> Best regards,
>> --
>> Dharma Balasubiramani <dharma.b@...rochip.com>
>>
> 
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com