linux-kernel - Re: [PATCH v1] cxl/port: Convert to use ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240829154344.00000f9c@Huawei.com>
Date: Thu, 29 Aug 2024 15:43:44 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Yuesong Li <liyuesong@...o.com>
CC: <dave@...olabs.net>, <dave.jiang@...el.com>, <alison.schofield@...el.com>,
	<vishal.l.verma@...el.com>, <ira.weiny@...el.com>,
	<dan.j.williams@...el.com>, <rrichter@....com>, <terry.bowman@....com>,
	<Benjamin.Cheatham@....com>, <linux-cxl@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <opensource.kernel@...o.com>
Subject: Re: [PATCH v1] cxl/port: Convert to use ERR_CAST()

On Thu, 29 Aug 2024 20:52:35 +0800
Yuesong Li <liyuesong@...o.com> wrote:

> Use ERR_CAST() as it is designed for casting an error pointer to
> another type.
> 
> This macro utilizes the __force and __must_check modifiers, which instruct
> the compiler to verify for errors at the locations where it is employed.
> 
> Signed-off-by: Yuesong Li <liyuesong@...o.com>

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  drivers/cxl/core/port.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index 1d5007e3795a..bdd3275ad417 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -941,7 +941,7 @@ struct cxl_root *devm_cxl_add_root(struct device *host,
>  
>  	port = devm_cxl_add_port(host, host, CXL_RESOURCE_NONE, NULL);
>  	if (IS_ERR(port))
> -		return (struct cxl_root *)port;
> +		return ERR_CAST(port);
>  
>  	cxl_root = to_cxl_root(port);
>  	cxl_root->ops = ops;