linux-kernel - Re: [PATCH nf-next v3 1/2] netfilter: Make IP_NF_IPTABLES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZtCNrKwfPx6dhORU@gmail.com>
Date: Thu, 29 Aug 2024 08:03:08 -0700
From: Breno Leitao <leitao@...ian.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: fw@...len.de, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, Pablo Neira Ayuso <pablo@...filter.org>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	David Ahern <dsahern@...nel.org>, Shuah Khan <shuah@...nel.org>,
	rbc@...a.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	netfilter-devel@...r.kernel.org,
	"open list:NETFILTER" <coreteam@...filter.org>,
	"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH nf-next v3 1/2] netfilter: Make IP_NF_IPTABLES_LEGACY
 selectable

On Thu, Aug 29, 2024 at 07:53:03AM -0700, Jakub Kicinski wrote:
> On Thu, 29 Aug 2024 03:08:01 -0700 Breno Leitao wrote:
> > > There are various configs in the tree. Grep for the configs you convert
> > > from select to depends on, they will all need updating.  
> > 
> > I am looking at all files that depend on these Kconfig options, and
> > there are a lot of tests.
> > 
> > Thinking more about the problem, it doesn't seem to be a good idea to
> > change dependency from all NF modules to NF_IPTABLES_LEGACY. In other
> > words, the `s/selects/depends on/` is the part that is causing all this
> > hassle, and it seems unnecessary.
> > 
> > That said, I would suggest we do not change the dependency, and keep the
> > "select NF_IPTABLES_LEGACY", and keep NF_IPTABLES_LEGACY user selectable.
> 
> Good idea, sounds much simpler!

Thanks, I will submit the patch soon.
--breno