linux-kernel - Re: [PATCH v2 0/4] arm64: dts: rockchip: Add Hardkernel ODROID-M1S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2d9da451-a553-4eb6-a0e3-067219de5302@kwiboo.se>
Date: Thu, 29 Aug 2024 17:07:12 +0200
From: Jonas Karlman <jonas@...boo.se>
To: jonesthefox@...oud.com
Cc: linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] arm64: dts: rockchip: Add Hardkernel ODROID-M1S

Hi Patrick,

On 2024-08-29 14:52, jonesthefox@...oud.com wrote:
> Hi Jonas,
> 
> I applied your four patches for the Odroid M1S to the mainline kernel [1], 
> compiled it using the kernel configuration from the Hardkernel Ubuntu 
> Server Image [2], and then attempted to boot into the official Generic 
> AArch64 image on mmcblk0 using a dtb file and an Arch Linux initrd by 
> manually copying the kernel and dtb file to the boot partition and 
> booting manually with the vendor's U-Boot [3]. 
> 
> The booting process was successful!
> 
> However, the network interface is not working. Here is the relevant 
> dmesg output:
> 
> ----
> [ 6.694455] rk_gmac-dwmac fe010000.ethernet: IRQ eth_lpi not found
> [ 6.695030] rk_gmac-dwmac fe010000.ethernet: IRQ sfty not found
> [ 6.702424] rk_gmac-dwmac fe010000.ethernet: clock input or output? (input).
> [ 6.703064] rk_gmac-dwmac fe010000.ethernet: Can not read property: tx_delay.
> [ 6.704461] rk_gmac-dwmac fe010000.ethernet: set tx_delay to 0x30
> [ 6.705002] rk_gmac-dwmac fe010000.ethernet: Can not read property: rx_delay.
> [ 6.709919] rk_gmac-dwmac fe010000.ethernet: set rx_delay to 0x10
> [ 6.710579] rk_gmac-dwmac fe010000.ethernet: integrated PHY? (no).
> [ 6.711180] rk_gmac-dwmac fe010000.ethernet: clock input from PHY
> [ 6.716749] rk_gmac-dwmac fe010000.ethernet: init for RGMII_ID
> [ 6.718117] rk_gmac-dwmac fe010000.ethernet: User ID: 0x30, Synopsys ID: 0x51
> [ 6.719022] rk_gmac-dwmac fe010000.ethernet: DWMAC4/5
> [ 6.719540] rk_gmac-dwmac fe010000.ethernet: DMA HW capability register supported
> [ 6.720204] rk_gmac-dwmac fe010000.ethernet: RX Checksum Offload Engine supported
> [ 6.720864] rk_gmac-dwmac fe010000.ethernet: TX Checksum insertion supported
> [ 6.721484] rk_gmac-dwmac fe010000.ethernet: Wake-Up On Lan supported
> [ 6.722155] rk_gmac-dwmac fe010000.ethernet: TSO supported
> [ 6.723019] rk_gmac-dwmac fe010000.ethernet: Enable RX Mitigation via HW Watchdog Timer
> [ 6.723761] rk_gmac-dwmac fe010000.ethernet: device MAC address 0e:c7:69:a9:f2:61
> [ 6.724436] rk_gmac-dwmac fe010000.ethernet: Enabled RFS Flow TC (entries=10)
> [ 6.725073] rk_gmac-dwmac fe010000.ethernet: TSO feature enabled
> [ 6.725609] rk_gmac-dwmac fe010000.ethernet: Using 32/32 bits DMA host/device width
> [ 6.998073] rk_gmac-dwmac fe010000.ethernet end0: renamed from eth0
> [ 7.096335] rk_gmac-dwmac fe010000.ethernet end0: Register MEM_TYPE_PAGE_POOL RxQ-0
> [ 7.097618] rk_gmac-dwmac fe010000.ethernet end0: __stmmac_open: Cannot attach to PHY (error: -19)
> ----
> 
> Does anyone have any idea what could be causing this issue, or if there 
> is anything I could try to get the network interface up and running?

This is more than likely an issue with the RTL8211F not being identified
because it needs to be reset before its phy-id can be read. See [4] for
an old topic on similar issue with RTL8211F on other boards.

Mainline U-Boot will reset the Ethernet PHY during boot and this will
help Linux identify it correctly. See [5] for mainline U-Boot for this
board. Will submit U-Boot patches once the DT has reached a tag in the
devicetree-rebasing repo.

Another possible solution (untested) would be to change the Ethernet PHY
compatible to "ethernet-phy-id001c.c916". That may help bootstrap Linux
into being able to reset and identify the PHY.

[4] https://lore.kernel.org/r/47d55aca-bee6-810f-379f-9431649fefa6@kwiboo.se/

[5] https://github.com/Kwiboo/u-boot-rockchip/commit/210dc397c1758c7666fa686a2da59e34010650ba
Branch: rk3xxx-2024.10, target: odroid-m1s-rk3566_defconfig

Regards,
Jonas

> 
> Thanks for your help!
> 
> Best regards,
> Patrick
> 
> [1] Linux Kernel Repository: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> Version: v6.11-rc5-50-g3ec3f5fc4a91
> 
> [2] Semi-official Hardkernel Ubuntu Server Preview Image for Odroid M1S: 
> https://forum.odroid.com/viewtopic.php?t=48230
> 
> [3] U-Boot Version: U-Boot 2017.09-g97ab962d1ed-230719 #tobetter (Oct 27 2023 - 14:54:41 +0900)