linux-kernel - Re: [PATCH 2/2] crypto: qcom-rng: fix support for ACPI-based systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABx5tqKJ9Swc3dF3wG46BUL9-zDpVNyqXLeuA92kOZCbNU_wCA@mail.gmail.com>
Date: Thu, 29 Aug 2024 12:13:03 -0400
From: Brian Masney <bmasney@...hat.com>
To: Ernesto A. Fernández <ernesto.mnd.fernandez@...il.com>
Cc: Jeffrey Hugo <quic_jhugo@...cinc.com>, herbert@...dor.apana.org.au, 
	davem@...emloft.net, quic_omprsing@...cinc.com, neil.armstrong@...aro.org, 
	quic_bjorande@...cinc.com, linux-arm-msm@...r.kernel.org, 
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] crypto: qcom-rng: fix support for ACPI-based systems

On Thu, Aug 29, 2024 at 11:58 AM Ernesto A. Fernández
<ernesto.mnd.fernandez@...il.com> wrote:
> thanks for the patch. I have one doubt:
>
> On Wed, Aug 28, 2024 at 09:20:05PM -0400, Brian Masney wrote:
> > The qcom-rng driver supports both ACPI and device tree based systems.
> > ACPI support was broken when the hw_random interface support was added.
> > Let's go ahead and fix this by checking has_acpi_companion().
> >
> > This fix was boot tested on a Qualcomm Amberwing server.
> >
> > Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support")
> > Signed-off-by: Brian Masney <bmasney@...hat.com>
> > ---
> >  drivers/crypto/qcom-rng.c | 36 ++++++++++++++++++++----------------
> >  1 file changed, 20 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c
> > index 4ed545001b77..470062cb258c 100644
> > --- a/drivers/crypto/qcom-rng.c
> > +++ b/drivers/crypto/qcom-rng.c
> > @@ -176,6 +176,21 @@ static struct rng_alg qcom_rng_alg = {
> >       }
> >  };
> >
> > +static struct qcom_rng_match_data qcom_prng_match_data = {
> > +     .skip_init = false,
>
> So with acpi, skip_init will be set to false now, right? But before
> f29cd5bb64c2 broke it, skip_init used to be set to true. Was that wrong
> before, or now?

Good catch! I didn't check the _DSD and assumed it was always false.
I'll verify on the server we have in the lab and post a v2.

Brian