linux-kernel - Re: [PATCH] nilfs2: Remove duplicate 'unlikely()' usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKFNMo=1xjz8ZPXHMeWk6dFcya+c3wrCD2=svh9XoeHxz01BZg@mail.gmail.com>
Date: Fri, 30 Aug 2024 01:47:00 +0900
From: Ryusuke Konishi <konishi.ryusuke@...il.com>
To: Kunwu Chan <kunwu.chan@...ux.dev>
Cc: linux-nilfs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Kunwu Chan <chentao@...inos.cn>
Subject: Re: [PATCH] nilfs2: Remove duplicate 'unlikely()' usage

On Thu, Aug 29, 2024 at 4:16 PM Kunwu Chan wrote:
>
> From: Kunwu Chan <chentao@...inos.cn>
>
> nested unlikely() calls, IS_ERR already uses unlikely() internally
>
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
> ---
>  fs/nilfs2/page.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nilfs2/page.c b/fs/nilfs2/page.c
> index 7797903e014e..9c0b7cddeaae 100644
> --- a/fs/nilfs2/page.c
> +++ b/fs/nilfs2/page.c
> @@ -262,7 +262,7 @@ int nilfs_copy_dirty_pages(struct address_space *dmap,
>                         NILFS_FOLIO_BUG(folio, "inconsistent dirty state");
>
>                 dfolio = filemap_grab_folio(dmap, folio->index);
> -               if (unlikely(IS_ERR(dfolio))) {
> +               if (IS_ERR(dfolio)) {
>                         /* No empty page is added to the page cache */
>                         folio_unlock(folio);
>                         err = PTR_ERR(dfolio);
> --
> 2.41.0
>

Thank you.  I'll pick it up.

Ryusuke Konishi