Message-ID: <mhng-77a89c0b-bfdf-4a6f-bb6e-cee3ff1efbc6@palmer-ri-x1c9>
Date: Thu, 29 Aug 2024 10:00:45 -0700 (PDT)
From: Palmer Dabbelt <palmer@...belt.com>
To: vbabka@...e.cz
CC: Charlie Jenkins <charlie@...osinc.com>, Arnd Bergmann <arnd@...db.de>,
  Richard Henderson <richard.henderson@...aro.org>, ink@...assic.park.msu.ru, mattst88@...il.com, vgupta@...nel.org,
  linux@...linux.org.uk, guoren@...nel.org, chenhuacai@...nel.org, kernel@...0n.name,
  tsbogend@...ha.franken.de, James.Bottomley@...senPartnership.com, deller@....de, mpe@...erman.id.au,
  npiggin@...il.com, christophe.leroy@...roup.eu, naveen@...nel.org, agordeev@...ux.ibm.com,
  gerald.schaefer@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com, borntraeger@...ux.ibm.com,
  svens@...ux.ibm.com, ysato@...rs.sourceforge.jp, dalias@...c.org, glaubitz@...sik.fu-berlin.de,
  davem@...emloft.net, andreas@...sler.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
  dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com, luto@...nel.org, peterz@...radead.org,
  muchun.song@...ux.dev, akpm@...ux-foundation.org, Liam.Howlett@...cle.com, lorenzo.stoakes@...cle.com,
  shuah@...nel.org, Linus Torvalds <torvalds@...ux-foundation.org>, linux-arch@...r.kernel.org,
  linux-kernel@...r.kernel.org, linux-alpha@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
  linux-arm-kernel@...ts.infradead.org, linux-csky@...r.kernel.org, loongarch@...ts.linux.dev,
  linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
  linux-s390@...r.kernel.org, linux-sh@...r.kernel.org, sparclinux@...r.kernel.org, linux-mm@...ck.org,
  linux-kselftest@...r.kernel.org, linux-api@...r.kernel.org
Subject:     Re: [PATCH RFC v2 0/4] mm: Introduce MAP_BELOW_HINT

On Thu, 29 Aug 2024 02:02:34 PDT (-0700), vbabka@...e.cz wrote:
> Such a large recipient list and no linux-api. CC'd, please include it on
> future postings.
>
> On 8/29/24 09:15, Charlie Jenkins wrote:
>> Some applications rely on placing data in free bits addresses allocated
>> by mmap. Various architectures (eg. x86, arm64, powerpc) restrict the
>> address returned by mmap to be less than the 48-bit address space,
>> unless the hint address uses more than 47 bits (the 48th bit is reserved
>> for the kernel address space).
>>
>> The riscv architecture needs a way to similarly restrict the virtual
>> address space. On the riscv port of OpenJDK an error is thrown if
>> attempted to run on the 57-bit address space, called sv57 [1].  golang
>> has a comment that sv57 support is not complete, but there are some
>> workarounds to get it to mostly work [2].
>>
>> These applications work on x86 because x86 does an implicit 47-bit
>> restriction of mmap() address that contain a hint address that is less
>> than 48 bits.
>>
>> Instead of implicitly restricting the address space on riscv (or any
>> current/future architecture), a flag would allow users to opt-in to this
>> behavior rather than opt-out as is done on other architectures. This is
>> desirable because it is a small class of applications that do pointer
>> masking.
>
> I doubt it's desirable to have different behavior depending on architecture.
> Also you could say it's a small class of applications that need more than 47
> bits.

We're sort of stuck with the architeture-depending behavior here: for 
the first few years RISC-V only had 39-bit VAs, so the defato uABI ended 
up being that userspace can ignore way more bits.  While 48 bits might 
be enough for everyone, 39 doesn't seem to be -- or at least IIRC when 
we tried restricting the default to that, we broke stuff.  There's also 
some other wrinkles like arbitrary bit boundaries in pointer masking and 
vendor-specific paging formats, but at some point we just end up down a 
rabbit hole of insanity there...

FWIW, I think that userspace depending on just tossing some VA bits 
because some kernels happened to never allocate from them is just 
broken, but it seems like other ports worked around the 48->57 bit 
transition and we're trying to do something similar for 39->48 (and that 
works with 49->57, as we'll have to deal with that eventually).

So that's basically how we ended up with this sort of thing: trying to 
do something similar without a flag broke userspace because we were 
trying to jam too much into the hints.  I couldn't really figure out a 
way to satisfy all the userspace constraints by just implicitly 
retrofitting behavior based on the hints, so we figured having an 
explicit flag to control the behavior would be the sanest way to go.

That said: I'm not opposed to just saying "depending on 39-bit VAs is 
broken" and just forcing people to fix it.

>> This flag will also allow seemless compatibility between all
>> architectures, so applications like Go and OpenJDK that use bits in a
>> virtual address can request the exact number of bits they need in a
>> generic way. The flag can be checked inside of vm_unmapped_area() so
>> that this flag does not have to be handled individually by each
>> architecture.
>>
>> Link:
>> https://github.com/openjdk/jdk/blob/f080b4bb8a75284db1b6037f8c00ef3b1ef1add1/src/hotspot/cpu/riscv/vm_version_riscv.cpp#L79
>> [1]
>> Link:
>> https://github.com/golang/go/blob/9e8ea567c838574a0f14538c0bbbd83c3215aa55/src/runtime/tagptr_64bit.go#L47
>> [2]
>>
>> To: Arnd Bergmann <arnd@...db.de>
>> To: Richard Henderson <richard.henderson@...aro.org>
>> To: Ivan Kokshaysky <ink@...assic.park.msu.ru>
>> To: Matt Turner <mattst88@...il.com>
>> To: Vineet Gupta <vgupta@...nel.org>
>> To: Russell King <linux@...linux.org.uk>
>> To: Guo Ren <guoren@...nel.org>
>> To: Huacai Chen <chenhuacai@...nel.org>
>> To: WANG Xuerui <kernel@...0n.name>
>> To: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
>> To: James E.J. Bottomley <James.Bottomley@...senPartnership.com>
>> To: Helge Deller <deller@....de>
>> To: Michael Ellerman <mpe@...erman.id.au>
>> To: Nicholas Piggin <npiggin@...il.com>
>> To: Christophe Leroy <christophe.leroy@...roup.eu>
>> To: Naveen N Rao <naveen@...nel.org>
>> To: Alexander Gordeev <agordeev@...ux.ibm.com>
>> To: Gerald Schaefer <gerald.schaefer@...ux.ibm.com>
>> To: Heiko Carstens <hca@...ux.ibm.com>
>> To: Vasily Gorbik <gor@...ux.ibm.com>
>> To: Christian Borntraeger <borntraeger@...ux.ibm.com>
>> To: Sven Schnelle <svens@...ux.ibm.com>
>> To: Yoshinori Sato <ysato@...rs.sourceforge.jp>
>> To: Rich Felker <dalias@...c.org>
>> To: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
>> To: David S. Miller <davem@...emloft.net>
>> To: Andreas Larsson <andreas@...sler.com>
>> To: Thomas Gleixner <tglx@...utronix.de>
>> To: Ingo Molnar <mingo@...hat.com>
>> To: Borislav Petkov <bp@...en8.de>
>> To: Dave Hansen <dave.hansen@...ux.intel.com>
>> To: x86@...nel.org
>> To: H. Peter Anvin <hpa@...or.com>
>> To: Andy Lutomirski <luto@...nel.org>
>> To: Peter Zijlstra <peterz@...radead.org>
>> To: Muchun Song <muchun.song@...ux.dev>
>> To: Andrew Morton <akpm@...ux-foundation.org>
>> To: Liam R. Howlett <Liam.Howlett@...cle.com>
>> To: Vlastimil Babka <vbabka@...e.cz>
>> To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
>> To: Shuah Khan <shuah@...nel.org>
>> Cc: linux-arch@...r.kernel.org
>> Cc: linux-kernel@...r.kernel.org
>> Cc: linux-alpha@...r.kernel.org
>> Cc: linux-snps-arc@...ts.infradead.org
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Cc: linux-csky@...r.kernel.org
>> Cc: loongarch@...ts.linux.dev
>> Cc: linux-mips@...r.kernel.org
>> Cc: linux-parisc@...r.kernel.org
>> Cc: linuxppc-dev@...ts.ozlabs.org
>> Cc: linux-s390@...r.kernel.org
>> Cc: linux-sh@...r.kernel.org
>> Cc: sparclinux@...r.kernel.org
>> Cc: linux-mm@...ck.org
>> Cc: linux-kselftest@...r.kernel.org
>> Signed-off-by: Charlie Jenkins <charlie@...osinc.com>
>>
>> Changes in v2:
>> - Added much greater detail to cover letter
>> - Removed all code that touched architecture specific code and was able
>>   to factor this out into all generic functions, except for flags that
>>   needed to be added to vm_unmapped_area_info
>> - Made this an RFC since I have only tested it on riscv and x86
>> - Link to v1: https://lore.kernel.org/r/20240827-patches-below_hint_mmap-v1-0-46ff2eb9022d@rivosinc.com
>>
>> ---
>> Charlie Jenkins (4):
>>       mm: Add MAP_BELOW_HINT
>>       mm: Add hint and mmap_flags to struct vm_unmapped_area_info
>>       mm: Support MAP_BELOW_HINT in vm_unmapped_area()
>>       selftests/mm: Create MAP_BELOW_HINT test
>>
>>  arch/alpha/kernel/osf_sys.c                  |  2 ++
>>  arch/arc/mm/mmap.c                           |  3 +++
>>  arch/arm/mm/mmap.c                           |  7 ++++++
>>  arch/csky/abiv1/mmap.c                       |  3 +++
>>  arch/loongarch/mm/mmap.c                     |  3 +++
>>  arch/mips/mm/mmap.c                          |  3 +++
>>  arch/parisc/kernel/sys_parisc.c              |  3 +++
>>  arch/powerpc/mm/book3s64/slice.c             |  7 ++++++
>>  arch/s390/mm/hugetlbpage.c                   |  4 ++++
>>  arch/s390/mm/mmap.c                          |  6 ++++++
>>  arch/sh/mm/mmap.c                            |  6 ++++++
>>  arch/sparc/kernel/sys_sparc_32.c             |  3 +++
>>  arch/sparc/kernel/sys_sparc_64.c             |  6 ++++++
>>  arch/sparc/mm/hugetlbpage.c                  |  4 ++++
>>  arch/x86/kernel/sys_x86_64.c                 |  6 ++++++
>>  arch/x86/mm/hugetlbpage.c                    |  4 ++++
>>  fs/hugetlbfs/inode.c                         |  4 ++++
>>  include/linux/mm.h                           |  2 ++
>>  include/uapi/asm-generic/mman-common.h       |  1 +
>>  mm/mmap.c                                    |  9 ++++++++
>>  tools/include/uapi/asm-generic/mman-common.h |  1 +
>>  tools/testing/selftests/mm/Makefile          |  1 +
>>  tools/testing/selftests/mm/map_below_hint.c  | 32 ++++++++++++++++++++++++++++
>>  23 files changed, 120 insertions(+)
>> ---
>> base-commit: 5be63fc19fcaa4c236b307420483578a56986a37
>> change-id: 20240827-patches-below_hint_mmap-b13d79ae1c55

Powered by blists - more mailing lists