linux-kernel - Re: [PATCH 01/18] Input: zforce_ts - use devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtC16tRKASOqXEk9@google.com>
Date: Thu, 29 Aug 2024 10:54:50 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Heiko Stübner <heiko@...ech.de>
Cc: linux-input@...r.kernel.org,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Andreas Kemnade <andreas@...nade.info>,
	linux-kernel@...r.kernel.org,
	Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
Subject: Re: [PATCH 01/18] Input: zforce_ts - use devm_add_action_or_reset()

On Sat, Aug 24, 2024 at 01:13:28PM +0200, Heiko Stübner wrote:
> Am Samstag, 24. August 2024, 07:50:25 CEST schrieb Dmitry Torokhov:
> > From: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> > 
> > If devm_add_action() fails we are explicitly calling the cleanup to free
> > the resources allocated. Lets use the helper devm_add_action_or_reset()
> > and return directly in case of error, as we know that the cleanup
> > function has been already called by the helper if there was any error.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> 
> mistmatch between From and first Signed-off-by

Yeah, I got this patch a while ago...

> 
> Other than that:
> Reviewed-by: Heiko Stuebner <heiko@...ech.de>

Is this for this patch only or for the whole series?

> 
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > ---
> >  drivers/input/touchscreen/zforce_ts.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/drivers/input/touchscreen/zforce_ts.c b/drivers/input/touchscreen/zforce_ts.c
> > index fdf2d1e770c8..ffbd55c6e1d4 100644
> > --- a/drivers/input/touchscreen/zforce_ts.c
> > +++ b/drivers/input/touchscreen/zforce_ts.c
> > @@ -803,15 +803,12 @@ static int zforce_probe(struct i2c_client *client)
> >  		udelay(100);
> >  	}
> >  
> > -	ret = devm_add_action(&client->dev, zforce_reset, ts);
> > +	ret = devm_add_action_or_reset(&client->dev, zforce_reset, ts);
> >  	if (ret) {
> >  		dev_err(&client->dev, "failed to register reset action, %d\n",
> >  			ret);
> >  
> >  		/* hereafter the regulator will be disabled by the action */
> > -		if (!IS_ERR(ts->reg_vdd))
> > -			regulator_disable(ts->reg_vdd);
> > -
> >  		return ret;
> >  	}
> >  
> > 
> 
> 
> 
> 

Thanks.

-- 
Dmitry