linux-kernel - Re: [PATCH v3] dma: Trace API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240829041912.GB4408@lst.de>
Date: Thu, 29 Aug 2024 06:19:12 +0200
From: Christoph Hellwig <hch@....de>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: Christoph Hellwig <hch@....de>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Robin Murphy <robin.murphy@....com>, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] dma: Trace API

I'd change the subject to

dma-mapping: add tracing for dma-mapping API calls

On Mon, Aug 26, 2024 at 04:32:40PM -0400, Sean Anderson wrote:
> When debugging drivers, it can often be useful to trace when memory gets
> (un)mapped for DMA (and can be accessed by the device). Add some
> tracepoints for this purpose.
> 
> We use unsigned long long instead of phys_addr_t and dma_addr_t (and
> similarly %llx instead of %pa) because libtraceevent can't handle
> typedefs.

and a __u64 would seem like the better type here.

otherwise this looks fine to me.  I can do the tweaks as I'll apply
the patch if needed.