linux-kernel - Re: [PATCH v3 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <75ffe2db-a5d5-471b-9e8b-53b98e75368e@web.de>
Date: Thu, 29 Aug 2024 07:10:06 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Hui-Ping Chen <hpchen0nvt@...il.com>, linux-mtd@...ts.infradead.org,
 linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org,
 linux-arm-kernel@...ts.infradead.org,
 Christian König <christian.koenig@....com>,
 Conor Dooley <conor+dt@...nel.org>, Esben Haabendal <esben@...nix.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Rob Herring <robh@...nel.org>,
 Sumit Semwal <sumit.semwal@...aro.org>, Vignesh Raghavendra <vigneshr@...com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] mtd: rawnand: nuvoton: add new driver for the
 Nuvoton MA35 SoC

> Nuvoton MA35 SoCs NAND Flash Interface Controller
> supports 2KB, 4KB and 8KB page size, and up to 8-bit,
> 12-bit, and 24-bit hardware ECC calculation circuit
> to protect data communication.

You may occasionally put more than 53 characters into text lines
of such a change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc5#n45


…
> +++ b/drivers/mtd/nand/raw/nuvoton_ma35d1_nand.c
> @@ -0,0 +1,1068 @@
…
> +static irqreturn_t ma35_nand_irq(int irq, void *id)
> +{
…
> +	u32 isr;
> +
> +	spin_lock(&nand->dma_lock);
…
> +	spin_unlock(&nand->dma_lock);
> +
> +	return IRQ_HANDLED;
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock)(&nand->dma_lock);”?
https://elixir.bootlin.com/linux/v6.11-rc5/source/include/linux/spinlock.h#L559

Regards,
Markus