linux-kernel - Re: [PATCH net-next 1/1] net: dsa: microchip: rename ksz8 series files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9066b22b221f97287484f1b961476ce6a67249df.camel@microchip.com>
Date: Thu, 29 Aug 2024 05:35:08 +0000
From: <Arun.Ramadoss@...rochip.com>
To: <andrew@...n.ch>, <olteanv@...il.com>, <davem@...emloft.net>,
	<Woojung.Huh@...rochip.com>, <f.fainelli@...il.com>, <kuba@...nel.org>,
	<vtpieter@...il.com>, <UNGLinuxDriver@...rochip.com>, <edumazet@...gle.com>,
	<pabeni@...hat.com>
CC: <pieter.van.trappen@...n.ch>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/1] net: dsa: microchip: rename ksz8 series
 files

Hi Pieter, 

On Wed, 2024-08-28 at 12:27 +0200, vtpieter@...il.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> From: Pieter Van Trappen <pieter.van.trappen@...n.ch>
> 
> The first KSZ8 series implementation was done for a KSZ8795 device
> but
> since several other KSZ8 devices have been added. Rename these files
> to adhere to the ksz8 naming convention as already used in most
> functions and the existing ksz8.h; add an explanatory note.

Refactoring the file name will better align what the implementation is.
But the file header/Kconfig should mentions what all the switches it
support. 
Because there are two switches KSZ8563 and KSZ8567 does not belong to
this Family. Instead it belongs to KSZ9477 family with only difference
they are not gigabit capable. 

The switch comes in KSZ8.c files are KSZ8863/KSZ8873,KSZ8895/KSZ8864,
KSZ8794/KSZ8795/KSZ8765.

> 
> In addition, remove one last register definition that is already part
> of the ksz_common.c register structures.

This should be separate patch.
>