linux-kernel - Re: [PATCH v3] Bluetooth: btrtl: Set msft ext address filter quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83b72389-e12b-4224-aed7-736880e2877f@molgen.mpg.de>
Date: Thu, 29 Aug 2024 08:13:53 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Hilda Wu <hildawu@...ltek.com>
Cc: marcel@...tmann.org, luiz.dentz@...il.com,
 linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
 alex_lu@...lsil.com.cn, max.chou@...ltek.com, kidman@...ltek.com
Subject: Re: [PATCH v3] Bluetooth: btrtl: Set msft ext address filter quirk

Dear Hilda,


Thank you for your patch.

Am 29.08.24 um 05:46 schrieb Hilda Wu:
> For tracking multiple devices concurrently with a condition.
> The patch enables the HCI_QUIRK_USE_MSFT_EXT_ADDRESS_FILTER quirk
> on RTL8852B controller.

Please add the controller name also to the commit message summary.

> The quirk setting is based on this commit.
> Commit 9e14606d8f38 ("Bluetooth: msft: Extended monitor tracking by
> address filter")

… is based on commit 9e14606d8f38 ("Bluetooth: msft: Extended monitor 
tracking by address filter").

> With this setting, when a pattern monitor detects a device, this
> feature issues an address monitor for tracking that device. Let the
> original pattern monitor can keep monitor new devices.

Remove *can*?

Please paste possible Linux message before/after the commit into the 
commit message.

> Signed-off-by: Hilda Wu <hildawu@...ltek.com>
> ---
> Change:
> v3: edit commit log and title
> v2: Add reference commit, update commit description
> ---
> ---
>   drivers/bluetooth/btrtl.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index 4c0f551a9975..2d95b3ea046d 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -1308,6 +1308,7 @@ void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
>   			btrealtek_set_flag(hdev, REALTEK_ALT6_CONTINUOUS_TX_CHIP);
>   
>   		if (btrtl_dev->project_id == CHIP_ID_8852A ||
> +		    btrtl_dev->project_id == CHIP_ID_8852B ||
>   		    btrtl_dev->project_id == CHIP_ID_8852C)
>   			set_bit(HCI_QUIRK_USE_MSFT_EXT_ADDRESS_FILTER, &hdev->quirks);


Kind regards,

Paul