linux-kernel - [PATCH v2 1/2] mmc: cqhci: Fix checking of CQHCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240829061823.3718-2-sh8267.baek@samsung.com>
Date: Thu, 29 Aug 2024 15:18:22 +0900
From: Seunghwan Baek <sh8267.baek@...sung.com>
To: linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
	ulf.hansson@...aro.org, ritesh.list@...il.com, quic_asutoshd@...cinc.com,
	adrian.hunter@...el.com
Cc: grant.jung@...sung.com, jt77.jang@...sung.com, junwoo80.lee@...sung.com,
	dh0421.hwang@...sung.com, jangsub.yi@...sung.com, sh043.lee@...sung.com,
	cw9316.lee@...sung.com, sh8267.baek@...sung.com, wkon.kim@...sung.com,
	stable@...r.kernel.org
Subject: [PATCH v2 1/2] mmc: cqhci: Fix checking of CQHCI_HALT state

To check if mmc cqe is in halt state, need to check set/clear of CQHCI_HALT
bit. At this time, we need to check with &, not &&.

Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host")
Cc: stable@...r.kernel.org
Signed-off-by: Seunghwan Baek <sh8267.baek@...sung.com>
---
 drivers/mmc/host/cqhci-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.c
index c14d7251d0bb..a02da26a1efd 100644
--- a/drivers/mmc/host/cqhci-core.c
+++ b/drivers/mmc/host/cqhci-core.c
@@ -617,7 +617,7 @@ static int cqhci_request(struct mmc_host *mmc, struct mmc_request *mrq)
 		cqhci_writel(cq_host, 0, CQHCI_CTL);
 		mmc->cqe_on = true;
 		pr_debug("%s: cqhci: CQE on\n", mmc_hostname(mmc));
-		if (cqhci_readl(cq_host, CQHCI_CTL) && CQHCI_HALT) {
+		if (cqhci_readl(cq_host, CQHCI_CTL) & CQHCI_HALT) {
 			pr_err("%s: cqhci: CQE failed to exit halt state\n",
 			       mmc_hostname(mmc));
 		}
-- 
2.17.1