linux-kernel - Re: [PATCH] tools/mm: Use calloc and check the potential memory allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <716f7466-562d-4bbe-a8ec-851a0b289db5@web.de>
Date: Thu, 29 Aug 2024 08:25:45 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Zhu Jun <zhujun2@...s.chinamobile.com>, linux-mm@...ck.org,
 kernel-janitors@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tools/mm: Use calloc and check the potential memory
 allocation failure

> Replace malloc with calloc and add memory allocating check

                      memset(…, 0, …) call by calloc()?

> of comm_str before used.

* Add also a null pointer check for the detection of a memory allocation failure.

* Would you like to improve such a change description another bit
  (with tags like “Fixes” and “Cc”)?

* How do you think about to omit the statement “fprintf(stderr, "Out of memory\n");”?

* I suggest to omit the word “potential” from the summary phrase.

Regards,
Markus