linux-kernel - Re: [PATCH 1/1] tools build: Remove leftover libcap tests that prevents fast path feature detection from working

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fX-Viz40=J+WQTT8PUDQ+Wtsj1sjA5ZPTxXY4eZo2eXUA@mail.gmail.com>
Date: Wed, 28 Aug 2024 23:32:06 -0700
From: Ian Rogers <irogers@...gle.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Adrian Hunter <adrian.hunter@...el.com>, Jiri Olsa <jolsa@...nel.org>, 
	Kan Liang <kan.liang@...ux.intel.com>, Namhyung Kim <namhyung@...nel.org>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/1] tools build: Remove leftover libcap tests that
 prevents fast path feature detection from working

On Wed, Aug 28, 2024 at 3:11 PM Arnaldo Carvalho de Melo
<acme@...nel.org> wrote:
>
> I noticed that the fast path feature detection was failing:
>
>   $ cat /tmp/build/perf-tools-next/feature/test-all.make.output
>   /usr/bin/ld: cannot find -lcap: No such file or directory
>   collect2: error: ld returned 1 exit status
>   $
>
> The patch removing the dependency (Fixes tag below) didn't remove the
> detection of libcap, and as the fast path feature detection (test-all.c)
> had -lcap in its Makefile link list of libraries to link, it was failing
> when libcap-devel is not available, fix it by removing those leftover
> files.

Isn't the feature test still in use by bpftool:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/bpf/bpftool/Makefile?h=perf-tools-next#n103
I'd deliberately not followed up in removing it because of this.

Thanks,
Ian