linux-kernel - Re: [PATCH -next] i3c: master: cdns: fix module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5faa10a-25e6-4793-99ad-dbcfe0ffee8b@quicinc.com>
Date: Thu, 29 Aug 2024 12:09:34 +0530
From: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
To: Liao Chen <liaochen4@...wei.com>, <linux-i3c@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
CC: <pgaj@...ence.com>, <alexandre.belloni@...tlin.com>
Subject: Re: [PATCH -next] i3c: master: cdns: fix module autoloading



On 8/26/2024 6:09 PM, Liao Chen wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@...wei.com>
> ---
>   drivers/i3c/master/i3c-master-cdns.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-master-cdns.c
> index c1627f3552ce..ee555255f1a2 100644
> --- a/drivers/i3c/master/i3c-master-cdns.c
> +++ b/drivers/i3c/master/i3c-master-cdns.c
> @@ -1562,6 +1562,7 @@ static const struct of_device_id cdns_i3c_master_of_ids[] = {
>   	{ .compatible = "cdns,i3c-master", .data = &cdns_i3c_devdata },
>   	{ /* sentinel */ },
>   };
> +MODULE_DEVICE_TABLE(of, cdns_i3c_master_of_ids);
>   
why not to use i3c as type instead of "of" ? Just curious, if it makes 
sense.
>   static int cdns_i3c_master_probe(struct platform_device *pdev)
>   {