linux-kernel - Re: [PATCH v4 0/2] Fix unmasking interrupt bit and remove watermark interrupt enablement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xadu7yiqbwwywemcmgfpz2x637dutntik7mdii4xp2vyipq4he@4gmbreitlui7>
Date: Thu, 29 Aug 2024 10:12:21 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Mrinmay Sarkar <quic_msarkar@...cinc.com>
Cc: manivannan.sadhasivam@...aro.org, vkoul@...nel.org, 
	quic_shazhuss@...cinc.com, quic_nitegupt@...cinc.com, quic_ramkri@...cinc.com, 
	quic_nayiluri@...cinc.com, quic_krichai@...cinc.com, quic_vbadigan@...cinc.com, 
	Cai Huoqing <cai.huoqing@...ux.dev>, dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/2] Fix unmasking interrupt bit and remove watermark
 interrupt enablement

On Mon, Aug 26, 2024 at 05:40:59PM +0530, Mrinmay Sarkar wrote:
> This patch series reset STOP_INT_MASK and ABORT_INT_MASK bit and unmask
> these interrupt for HDMA.
> 
> and also remove enablement of local watermark interrupt enable(LWIE)
> and remote watermarek interrupt enable(RWIE) bit to avoid unnecessary
> watermark interrupt event.
> 
> Testing
> -------
> 
> Tested on Qualcomm SA8775P Platform.
> 
> V3 -> V4:
> - convert IRQs unmasking in a clearer way as suggested by Serge.

Thanks for submitting the update. The patches have already been merged
in, but anyway here is my tag:

Reviewed-by: Serge Semin <fancer.lancer@...il.com>

-Serge(y)

> 
> V2 -> V3:
> - convert 'STOP, ABORT' to 'stop, abort' as suggested by Serge
> - Added Reviewed-by tag
> 
> V1 -> V2:
> - Modified commit message and added Fixes, CC tag as suggested by Mani
> - reanme done to STOP
> - rename DW_HDMA_V0_LIE -> DW_HDMA_V0_LWIE and DW_HDMA_V0_RIE -> DW_HDMA_V0_RWIE
> 
> Mrinmay Sarkar (2):
>   dmaengine: dw-edma: Fix unmasking STOP and ABORT interrupts for HDMA
>   dmaengine: dw-edma: Do not enable watermark interrupts for HDMA
> 
>  drivers/dma/dw-edma/dw-hdma-v0-core.c | 26 ++++++++------------------
>  1 file changed, 8 insertions(+), 18 deletions(-)
> 
> -- 
> 2.7.4
>