linux-kernel - Re: [PATCH v2 05/14] mm: khugepaged: __collapse_huge_page_swapin() use pte_offset_map_ro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3BAB5012-B8A5-4DFF-9CAB-31D44AEEB4F4@linux.dev>
Date: Thu, 29 Aug 2024 15:25:19 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: Qi Zheng <zhengqi.arch@...edance.com>
Cc: David Hildenbrand <david@...hat.com>,
 Hugh Dickins <hughd@...gle.com>,
 Matthew Wilcox <willy@...radead.org>,
 "Vlastimil Babka (SUSE)" <vbabka@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Mike Rapoport <rppt@...nel.org>,
 vishal.moola@...il.com,
 peterx@...hat.com,
 ryan.roberts@....com,
 christophe.leroy2@...soprasteria.com,
 linux-kernel@...r.kernel.org,
 linux-mm@...ck.org,
 linux-arm-kernel@...ts.infradead.org,
 linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2 05/14] mm: khugepaged: __collapse_huge_page_swapin()
 use pte_offset_map_ro_nolock()



> On Aug 22, 2024, at 15:13, Qi Zheng <zhengqi.arch@...edance.com> wrote:
> 
> In __collapse_huge_page_swapin(), we just use the ptl for pte_same() check
> in do_swap_page(). In other places, we directly use pte_offset_map_lock(),
> so convert it to using pte_offset_map_ro_nolock().
> 
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>

Reviewed-by: Muchun Song <muchun.song@...ux.dev>