linux-kernel - Re: [PATCH v3 4/7] arm64: dts: ti: k3-am65-main: Add VMAP registers to PCI root complexes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d215ba71-c652-4c2c-aa19-7c7613a9dd4d@siemens.com>
Date: Thu, 29 Aug 2024 09:34:15 +0200
From: Jan Kiszka <jan.kiszka@...mens.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Nishanth Menon <nm@...com>, Santosh Shilimkar <ssantosh@...nel.org>,
 Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-pci@...r.kernel.org, Siddharth Vadapalli <s-vadapalli@...com>,
 Bao Cheng Su <baocheng.su@...mens.com>, Hua Qian Li
 <huaqian.li@...mens.com>, Diogo Ivo <diogo.ivo@...mens.com>
Subject: Re: [PATCH v3 4/7] arm64: dts: ti: k3-am65-main: Add VMAP registers
 to PCI root complexes

On 29.08.24 08:12, Krzysztof Kozlowski wrote:
> On Wed, Aug 28, 2024 at 08:01:17PM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@...mens.com>
>>
>> Rewrap the long lines at this chance.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
>> ---
>>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 18 ++++++++++++++----
>>  1 file changed, 14 insertions(+), 4 deletions(-)
>>
> 
> You still have DTS packed in the middle of driver changes, suggesting
> dependency.
> 
> Such ordering does not make sense, because entire DTS goes separate tree
> and branch. It only complicates stuff because if you have dependency,
> which you cannot have, it won't be that easily visible.
> 
> You already got the same comment.
> 
> Please fix your driver to remove dependency and ABI break, and then fix
> the patch order.
> 

Could you be a bit more precise in your review, please? Should I also
pull the last patch to front, or more all DT changes into a separate series?

The PCI driver will not fail unless you ask it for the new feature
(CONFIG_TI_PVU) AND provide an incomplete DT (DMA pools, but no VMAP regs).

Thanks,
Jan

-- 
Siemens AG, Technology
Linux Expert Center