[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <i2ze6a6c7r5sfj56zrcn6ybr3juvd26sjdum4el6doqmpk7veb@pjj7jz45vf7s>
Date: Thu, 29 Aug 2024 09:44:23 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nikunj Kela <quic_nkela@...cinc.com>
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, rafael@...nel.org, viresh.kumar@...aro.org,
herbert@...dor.apana.org.au, davem@...emloft.net, sudeep.holla@....com, andi.shyti@...nel.org,
tglx@...utronix.de, will@...nel.org, joro@...tes.org, jassisinghbrar@...il.com,
lee@...nel.org, linus.walleij@...aro.org, amitk@...nel.org,
thara.gopinath@...il.com, broonie@...nel.org, wim@...ux-watchdog.org, linux@...ck-us.net,
robin.murphy@....com, cristian.marussi@....com, rui.zhang@...el.com,
lukasz.luba@....com, vkoul@...nel.org, quic_gurus@...cinc.com, agross@...nel.org,
bartosz.golaszewski@...aro.org, quic_rjendra@...cinc.com, robimarko@...il.com,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-pm@...r.kernel.org, linux-crypto@...r.kernel.org, arm-scmi@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org, iommu@...ts.linux.dev,
linux-gpio@...r.kernel.org, linux-serial@...r.kernel.org, linux-spi@...r.kernel.org,
linux-watchdog@...r.kernel.org, kernel@...cinc.com, quic_psodagud@...cinc.com,
quic_tsoni@...cinc.com, quic_shazhuss@...cinc.com,
Praveen Talari <quic_ptalari@...cinc.com>
Subject: Re: [PATCH 19/22] dt-bindings: i2c: document support for SA8255p
On Wed, Aug 28, 2024 at 01:37:18PM -0700, Nikunj Kela wrote:
> Add compatible representing i2c support on SA8255p.
>
> Clocks and interconnects are being configured in Firmware VM
> on SA8255p, therefore making them optional.
>
> CC: Praveen Talari <quic_ptalari@...cinc.com>
> Signed-off-by: Nikunj Kela <quic_nkela@...cinc.com>
> ---
> .../bindings/i2c/qcom,i2c-geni-qcom.yaml | 56 ++++++++++++-------
> 1 file changed, 36 insertions(+), 20 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> index 9f66a3bb1f80..88f513fc5b08 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> @@ -15,14 +15,13 @@ properties:
> enum:
> - qcom,geni-i2c
> - qcom,geni-i2c-master-hub
> + - qcom,sa8255p-geni-i2c
Same as in other patches, this does not make sense. What is the point of
generic compatibles?
>
> clocks:
> - minItems: 1
> - maxItems: 2
Nope.
> + description: phandles for the clock providers
Useless description. This cannot be anything else than phandles for the
clock providers.
Best regards,
Krzysztof
Powered by blists - more mailing lists