linux-kernel - Re: [PATCH] x86/sgx: Fix deadloop in __sgx_alloc_epc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cf0b2677ec6239a1fd7aa1b3ee101667c7b06b8.camel@intel.com>
Date: Thu, 29 Aug 2024 07:47:42 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "jarkko@...nel.org" <jarkko@...nel.org>, "Lu, Aaron" <aaron.lu@...el.com>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
CC: "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>, "Luo, Zhimin"
	<zhimin.luo@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH] x86/sgx: Fix deadloop in __sgx_alloc_epc_page()

On Thu, 2024-08-29 at 10:38 +0800, Aaron Lu wrote:
> When current node doesn't have a EPC section configured by firmware and
> all other EPC sections memory are used up, CPU can stuck inside the
> while loop in __sgx_alloc_epc_page() forever and soft lockup will happen.
> Note how nid_of_current will never equal to nid in that while loop because
> nid_of_current is not set in sgx_numa_mask.
> 
> Also worth mentioning is that it's perfectly fine for firmware to not
> seup an EPC section on a node. Setting an EPC section on each node can

seup -> set up.

> be good for performance but that's not a requirement functionality wise.
> 
> Fixes: 901ddbb9ecf5 ("x86/sgx: Add a basic NUMA allocation scheme to sgx_alloc_epc_page()")
> Reported-by: Zhimin Luo <zhimin.luo@...el.com>
> Tested-by: Zhimin Luo <zhimin.luo@...el.com>
> Signed-off-by: Aaron Lu <aaron.lu@...el.com>

Reviewed-by: Kai Huang <kai.huang@...el.com>